scripts/slave/recipe_modules/auto_bisect/bisector.py - Issue 1825993003: Making check_initial_confidence verify return_code bisects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 1825993003: Making check_initial_confidence verify return_code bisects. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Removing unnecessary mocks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/auto_bisect/bisector.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py

index b2002b08ce0931a0639d6a13743388ed0a833c87..3e11582776b66fa8e3861d26c1f372c13764e050 100644

--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py

+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py

@@ -487,8 +487,9 @@ class Bisector(object):

other in a statistically significant manner. False if such difference could

not be established in the time or sample size allowed.

"""

- if self.test_type != 'perf':

- return True

+ if self.test_type == 'return_code':

+ return (self.good_rev.overall_return_code !=

+ self.bad_rev.overall_return_code)

if self.bypass_stats_check:

dummy_result = self.good_rev.values != self.bad_rev.values

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/auto_bisect/bisector_test.py » ('j') | no next file with comments »