Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3629)

Unified Diff: build/android/adb_gdb

Issue 1825933002: Add the url optional argument to adb_gdb --start. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/adb_gdb
diff --git a/build/android/adb_gdb b/build/android/adb_gdb
index 16139c7176e44afc440e2cb5e7385e588576b458..9923d5d76686f7be9d1e3c4140788d23034e745b 100755
--- a/build/android/adb_gdb
+++ b/build/android/adb_gdb
@@ -102,6 +102,7 @@ PULL_LIBS_DIR=
SANDBOXED=
SANDBOXED_INDEX=
START=
+START_URL=
ATTACH_DELAY=1
SU_PREFIX=
SYMBOL_DIR=
@@ -174,6 +175,9 @@ for opt; do
--script=*)
GDBINIT=$optarg
;;
+ --start=*)
+ START_URL=$optarg
+ ;& # fallthrough
--start)
START=true
;;
@@ -308,7 +312,7 @@ Valid options:
--program-name=<name> Specify program name (cosmetic only).
--pid=<pid> Specify application process pid.
--force Kill any previous debugging session, if any.
- --start Start package's activity on device.
+ --start[=<url>] Start package's activity on device.
--attach-delay=<num> Seconds to wait for gdbserver to attach to the
remote process before starting gdb. Default 1.
<num> may be a float if your sleep(1) supports it.
@@ -682,7 +686,7 @@ fi
if [ "$START" ]; then
log "Starting $PROGRAM_NAME on device."
- adb_shell am start -n $PACKAGE_NAME/$ACTIVITY 2>/dev/null
+ adb_shell am start -n $PACKAGE_NAME/$ACTIVITY ${START_URL:+-d "$START_URL"}
adb_shell ps | grep -q $PACKAGE_NAME
fail_panic "Could not start $PROGRAM_NAME on device. Are you sure the \
package is installed?"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698