Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 1825933002: Add the url optional argument to adb_gdb --start. (Closed)

Created:
4 years, 9 months ago by avallee
Modified:
4 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add the url optional argument to adb_gdb --start. Allow the start option to specify an optional argument of <url> to be started. BUG=597325 Committed: https://crrev.com/c1a5c49e7ceb310e919697fde616f4ca1a081c1a Cr-Commit-Position: refs/heads/master@{#384167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/android/adb_gdb View 4 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
avallee
PTAL.
4 years, 9 months ago (2016-03-23 18:21:47 UTC) #2
agrieve
On 2016/03/23 18:21:47, avallee wrote: > PTAL. lgtm!
4 years, 8 months ago (2016-03-31 00:19:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825933002/1
4 years, 8 months ago (2016-03-31 00:21:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 01:03:05 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 01:04:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1a5c49e7ceb310e919697fde616f4ca1a081c1a
Cr-Commit-Position: refs/heads/master@{#384167}

Powered by Google App Engine
This is Rietveld 408576698