Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 182593002: Added unit test for base/hash. (Closed)

Created:
6 years, 9 months ago by Matt Giuca
Modified:
6 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Added unit test for base/hash. This code is being moved into third_party, and it should be unit tested before the move to ensure nothing breaks. BUG=347393 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A base/hash_unittest.cc View 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Giuca
This is a precursor to the following CL: https://codereview.chromium.org/181643004/ In that CL, I am replacing ...
6 years, 9 months ago (2014-02-27 02:45:37 UTC) #1
brettw
lgtm
6 years, 9 months ago (2014-02-27 19:16:16 UTC) #2
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 9 months ago (2014-02-27 23:04:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/182593002/1
6 years, 9 months ago (2014-02-27 23:08:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/182593002/1
6 years, 9 months ago (2014-02-28 01:12:31 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 05:54:49 UTC) #6
Message was sent while issue was closed.
Change committed as 254053

Powered by Google App Engine
This is Rietveld 408576698