Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1825913003: media: Disable the unified media pipeline for API levels 16 & 17 (Closed)

Created:
4 years, 9 months ago by watk
Modified:
4 years, 8 months ago
Reviewers:
DaleCurtis
CC:
liberato (no reviews please), chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Disable the unified media pipeline for API levels 16 & 17 AVDA still has bugs on these older platform versions so this CL disables the unified media pipeline trial on them. BUG=597467 Committed: https://crrev.com/fc080ed13685df21f03c28c01008d5461cdbcf85 Cr-Commit-Position: refs/heads/master@{#383608}

Patch Set 1 #

Total comments: 1

Patch Set 2 : dale's coment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M media/base/media.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
watk
4 years, 9 months ago (2016-03-24 03:12:51 UTC) #2
DaleCurtis
lgtm https://codereview.chromium.org/1825913003/diff/1/media/base/media.cc File media/base/media.cc (right): https://codereview.chromium.org/1825913003/diff/1/media/base/media.cc#newcode111 media/base/media.cc:111: if (enabled_via_cli) Seems cleaner as return "enabled_via_cli || ...
4 years, 9 months ago (2016-03-24 03:16:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825913003/20001
4 years, 8 months ago (2016-03-28 23:37:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-28 23:41:49 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 23:43:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc080ed13685df21f03c28c01008d5461cdbcf85
Cr-Commit-Position: refs/heads/master@{#383608}

Powered by Google App Engine
This is Rietveld 408576698