Issue 18259016: Introduce isHTMLLabelElement and toHTMLLabelElement

Issue 18259016: Introduce isHTMLLabelElement and toHTMLLabelElement (Closed)

Created:
7 years, 5 months ago by kangil_

Modified:
7 years, 5 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, dmazzoni, eae+blinkwatch, adamk+blink_chromium.org, aboxhall

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Introduce isHTMLLabelElement and toHTMLLabelElement To avoid direct use of static_cast, this patch introduces isHTMLLabelElement and toHTMLLabelElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153743

Patch Set 1 #

Total comments: 2

Patch Set 2 : Took tkent's comment into consideration #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -21 lines)			Patch
M	Source/WebKit/chromium/src/WebLabelElement.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/accessibility/AXObjectCache.cpp	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/core/accessibility/AccessibilityNodeObject.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/accessibility/AccessibilityRenderObject.cpp	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/DocumentOrderedMap.cpp	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/TreeScope.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLLabelElement.h	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	Source/core/html/LabelsNodeList.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/18259016/diff/1/Source/core/accessibility/AXObjectCache.cpp File Source/core/accessibility/AXObjectCache.cpp (right): https://codereview.chromium.org/18259016/diff/1/Source/core/accessibility/AXObjectCache.cpp#newcode822 Source/core/accessibility/AXObjectCache.cpp:822: ASSERT(isHTMLLabelElement(element)); This line should be removed. toHTMLLabelElement below contains ...

7 years, 5 months ago (2013-07-09 02:38:12 UTC) #1

kangil_

On 2013/07/09 02:38:12, tkent wrote: > https://codereview.chromium.org/18259016/diff/1/Source/core/accessibility/AXObjectCache.cpp > File Source/core/accessibility/AXObjectCache.cpp (right): > > https://codereview.chromium.org/18259016/diff/1/Source/core/accessibility/AXObjectCache.cpp#newcode822 > ...

7 years, 5 months ago (2013-07-09 02:45:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/18259016/4001

7 years, 5 months ago (2013-07-09 03:01:52 UTC) #4

Message was sent while issue was closed.

Change committed as 153743

Expand Messages | Collapse Messages