Object ID Ring with tests

runtime/vm/isolate.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ISOLATE_H_
 #define VM_ISOLATE_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/thread.h"
@@ skipping 37 matching lines @@
 class RawError;
 class RawFloat32x4;
 class RawUint32x4;
 class Simulator;
 class StackResource;
 class StackZone;
 class StubCode;
 class TypeArguments;
 class TypeParameter;
 class ObjectHistogram;
+class ObjectIdRing;
 
 
 // Used by the deoptimization infrastructure to defer allocation of unboxed
 // objects until frame is fully rewritten and GC is safe.
 // Describes a stack slot that should be populated with a reference to the
 // materialized object.
 class DeferredSlot {
  public:
   DeferredSlot(RawInstance** slot, DeferredSlot* next)
       : slot_(slot), next_(next) { }
@@ skipping 548 matching lines @@
   intptr_t UnblockClassFinalization() {
     ASSERT(defer_finalization_count_ > 0);
     return defer_finalization_count_--;
   }
 
   bool AllowClassFinalization() {
     ASSERT(defer_finalization_count_ >= 0);
     return defer_finalization_count_ == 0;
   }
 
+  void set_object_id_ring(ObjectIdRing* ring);

[Ivan Posva, 2013/07/10 01:10:13]

Please put this up above with the other trivial accessors. Also it is
object_id_ring() and set_object_id_ring(), not the missing get_.

[Cutch, 2013/07/10 17:23:10]

Done.

+  ObjectIdRing* get_object_id_ring() {
+    return object_id_ring_;
+  }
+
  private:
   Isolate();
 
   void BuildName(const char* name_prefix);
   void PrintInvokedFunctions();
 
   static bool FetchStacktrace();
   static bool FetchStackFrameDetails();
   char* GetStatusDetails();
   char* GetStatusStacktrace();
@@ skipping 43 matching lines @@
   DeferredSlot* deferred_object_refs_;
 
   intptr_t deferred_objects_count_;
   DeferredObject** deferred_objects_;
 
   // Status support.
   char* stacktrace_;
   intptr_t stack_frame_index_;
   ObjectHistogram* object_histogram_;
 
+  // Ring buffer of objects assigned an id.
+  ObjectIdRing* object_id_ring_;
+
   // Reusable handles support.
 #define REUSABLE_HANDLE_FIELDS(object)                                         \
   object* object##_handle_;                                                    \
 
   REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_FIELDS)
 #undef REUSABLE_HANDLE_FIELDS
   VMHandles reusable_handles_;
 
   static Dart_IsolateCreateCallback create_callback_;
   static Dart_IsolateInterruptCallback interrupt_callback_;
@@ skipping 192 matching lines @@
 
  private:
   Isolate::IsolateRunState saved_state_;
 
   DISALLOW_COPY_AND_ASSIGN(IsolateRunStateManager);
 };
 
 }  // namespace dart
 
 #endif  // VM_ISOLATE_H_