Object ID Ring with tests

runtime/vm/heap.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_HEAP_H_
 #define VM_HEAP_H_
 
 #include "platform/assert.h"
 #include "vm/allocation.h"
 #include "vm/flags.h"
@@ skipping 213 matching lines @@
     ASSERT((id >= 0) && (id < GCStats::kDataEntries));
     stats_.data_[id] = value;
   }
 
   bool gc_in_progress() const { return gc_in_progress_; }
 
   static bool IsAllocatableInNewSpace(intptr_t size) {
     return size <= kNewAllocatableSize;
   }
 
+  void set_object_id_ring_table(RawObject** object_id_ring_table,

[Ivan Posva, 2013/07/10 01:10:13]

How about set_object_id_table and object_id_table()?

[Cutch, 2013/07/10 17:23:10]

Done.

+                                intptr_t object_id_ring_table_size) {
+    ASSERT(!gc_in_progress_);
+    object_id_ring_table_ = object_id_ring_table;
+    object_id_ring_table_size_ = object_id_ring_table_size;
+  }
+  RawObject** get_object_id_ring_table() {

[Ivan Posva, 2013/07/10 01:10:13]

Why does this return the naked internals of the ObjectIdRing object and not the
ObjectIdRing? Do you really need it here, or why does the code that needs access
to the ObjectIdRing not get it from the isolate itself?

[Cutch, 2013/07/10 17:23:10]

I've killed this and now the marker and scavenger get the ring from the isolate
directly.

+    return object_id_ring_table_;
+  }
+  intptr_t get_object_id_ring_table_size() {
+    return object_id_ring_table_size_;
+  }
+
  private:
   class GCStats : public ValueObject {
    public:
     GCStats() {}
     intptr_t num_;
     Heap::Space space_;
     Heap::GCReason reason_;
 
     class Data : public ValueObject {
     public:
@@ skipping 42 matching lines @@
 
   // GC stats collection.
   GCStats stats_;
 
   // This heap is in read-only mode: No allocation is allowed.
   bool read_only_;
 
   // GC on the heap is in progress.
   bool gc_in_progress_;
 
+  // Ring of objects who have a vm service id assigned to them.
+  RawObject** object_id_ring_table_;
+  intptr_t object_id_ring_table_size_;
+
   friend class GCTestHelper;
   DISALLOW_COPY_AND_ASSIGN(Heap);
 };
 
 
 #if defined(DEBUG)
 class NoGCScope : public StackResource {
  public:
   NoGCScope();
   ~NoGCScope();
@@ skipping 15 matching lines @@
   NoHeapGrowthControlScope();
   ~NoHeapGrowthControlScope();
  private:
   bool current_growth_controller_state_;
   DISALLOW_COPY_AND_ASSIGN(NoHeapGrowthControlScope);
 };
 
 }  // namespace dart
 
 #endif  // VM_HEAP_H_