tests/pnacl_dynamic_loading/pll_symbols_test.cc - Issue 1825893002: PNaCl Dynamic Linking: Added portable dependencies to shared objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/pnacl_dynamic_loading/pll_symbols_test.cc

Issue 1825893002: PNaCl Dynamic Linking: Added portable dependencies to shared objects. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Bumping Feature Version Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/pnacl_dynamic_loading/pll_symbols_test.cc

diff --git a/tests/pnacl_dynamic_loading/pll_symbols_test.cc b/tests/pnacl_dynamic_loading/pll_symbols_test.cc

index c9716c023fbef729ce1592353473397d232e8fe9..0bf4a70b1d2e157c3d7e7edbf7ba68099fc2e5cd 100644

--- a/tests/pnacl_dynamic_loading/pll_symbols_test.cc

+++ b/tests/pnacl_dynamic_loading/pll_symbols_test.cc

@@ -173,9 +173,9 @@ void TestCoreFunctionality(const char *test_dso_file) {

// Test dependencies.

ASSERT_EQ(pll_root->dependencies_count, 2);

- ASSERT_EQ(strcmp(pll_root->dependencies_list, "libfoo.so"), 0);

- ASSERT_EQ(strcmp(pll_root->dependencies_list + strlen("libfoo.so") + 1,

- "libbar.so"), 0);

+ ASSERT_EQ(strcmp(pll_root->dependencies_list, "test_pll_a.so"), 0);

+ ASSERT_EQ(strcmp(pll_root->dependencies_list + strlen("test_pll_a.so") + 1,

+ "test_pll_b.so"), 0);

// Test exports.

« no previous file with comments | « tests/pnacl_dynamic_loading/pll_loader_test.cc ('k') | tests/pnacl_dynamic_loading/test_pll_c.c » ('j') | no next file with comments »