Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Unified Diff: pnacl/driver/filetype.py

Issue 1825893002: PNaCl Dynamic Linking: Added portable dependencies to shared objects. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Bumping Feature Version Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pnacl/build.sh ('k') | pnacl/driver/pnacl-ld.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pnacl/driver/filetype.py
diff --git a/pnacl/driver/filetype.py b/pnacl/driver/filetype.py
index 898c023dffdf3127cfb250f42d2dee3fa43bd013..a4a315d193efd243128de9aec8160bcb7939d81d 100644
--- a/pnacl/driver/filetype.py
+++ b/pnacl/driver/filetype.py
@@ -67,6 +67,10 @@ def IsNativeDSO(filename):
return FileType(filename) == 'so'
@SimpleCache
+def IsPll(filename):
+ return FileType(filename) == 'pll'
+
+@SimpleCache
def GetBitcodeMagic(filename):
fp = driver_log.DriverOpen(filename, 'rb')
header = fp.read(4)
@@ -349,6 +353,10 @@ def FileType(filename):
return 'po'
if IsPNaClBitcode(filename):
+ # Although this file has the same extension as a native ".so", it actually
+ # is in a portable format and should be handled slightly differently.
+ if ext == 'so':
+ return 'pll'
return 'pexe'
if IsLinkerScript(filename):
« no previous file with comments | « pnacl/build.sh ('k') | pnacl/driver/pnacl-ld.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698