PNaCl Dynamic Linking: Added portable dependencies to shared objects.

src/untrusted/pll_loader/pll_loader.h

Index: src/untrusted/pll_loader/pll_loader.h
diff --git a/src/untrusted/pll_loader/pll_loader.h b/src/untrusted/pll_loader/pll_loader.h
index 0cdecc352c313e24ef0485a12773d155cc6a6ce3..cb833c5911ccfd16e0c40bc4b1f9bb303bc1dd3b 100644
--- a/src/untrusted/pll_loader/pll_loader.h
+++ b/src/untrusted/pll_loader/pll_loader.h
@@ -19,7 +19,7 @@ class PLLModule {
 
   static uint32_t HashString(const char *sp);
 
-  const PLLRoot *root() { return root_; }
+  const PLLRoot *root() const { return root_; }

[Mark Seaborn, 2016/04/01 23:42:19]

Nit: The whole PLLModule object is stateless since it just wraps a pointer.  So
there's really no difference between a PLLModule and a "const PLLModule", so I
would recommend not using the latter.  Adding "const" to this method suggests
that the others aren't const, which would be misleading since that's not the
case.

[Sean Klein, 2016/04/02 00:50:33]

Got it. Const removed from this function. To compile, "module" in
"AddByFilename" has been made non-const.

 
   const char *GetExportedSymbolName(size_t i) {
     return root_->string_table + root_->exported_names[i];
@@ -46,13 +46,15 @@ class ModuleSet {
  public:
   // Load a PLL by filename. Does not add the filename to a known set of loaded
   // modules, and will not de-duplicate loading modules.
-  void AddByFilename(const char *filename);
+  // Returns a pointer to the PLL's pso_root.

[Mark Seaborn, 2016/04/01 23:42:19]

Nit: Should return a PLLRoot* rather than void* then, surely?  Same below.

[Sean Klein, 2016/04/02 00:50:33]

Done.

+  void *AddByFilename(const char *filename);
 
   // Change the search path used by the linker when looking for PLLs by soname.
   void SetSonameSearchPath(const std::vector<std::string> &dir_list);
 
   // Load a PLL by soname and add the soname to the set of loaded modules.
-  void AddBySoname(const char *soname);
+  // Returns a pointer to the PLL's pso_root if it is loaded, NULL otherwise.
+  void *AddBySoname(const char *soname);
 
   // Looks up a symbol in the set of modules.  This does a linear search of
   // the modules, in the order that they were added using AddByFilename().