PNaCl Dynamic Linking: Added portable dependencies to shared objects.

tests/pnacl_dynamic_loading/nacl.scons

Index: tests/pnacl_dynamic_loading/nacl.scons
diff --git a/tests/pnacl_dynamic_loading/nacl.scons b/tests/pnacl_dynamic_loading/nacl.scons
index 3613d90b081baf78b1a6df55e0b5ae552cc2eaf0..6bc2729d5351058c72361707183ebd4efde7877d 100644
--- a/tests/pnacl_dynamic_loading/nacl.scons
+++ b/tests/pnacl_dynamic_loading/nacl.scons
@@ -21,14 +21,14 @@ if env.Bit('build_mips32'):
 if env.Bit('use_sandboxed_translator'):
   Return()
 
-
-def FinalizeAndTranslatePso(dest, opt_result):
+def FinalizePso(dest, opt_result):
   # Finalize to strip debugging info and to emit PNaCl bitcode.
-  finalized_result = env.Command(
-      dest + '.final.pso', [opt_result],
-      '${PNACLFINALIZE} ${SOURCES} -o ${TARGET}')
+  return env.Command(dest + '.so', [opt_result],
+                     '${PNACLFINALIZE} ${SOURCES} -o ${TARGET}')
+

[Mark Seaborn, 2016/03/30 23:24:57]

Style nit: In Python it's preferred to have 2 empty lines between top-level
function decls, so can you preserve that when the code has it already?

[Sean Klein, 2016/04/01 23:12:25]

Done.

+def TranslatePso(dest, finalized_result):
   # Translate to an ELF loadable object.
-  return env.Command(dest + '.so', [finalized_result],
+  return env.Command(dest + '.so.translated', [finalized_result],
                      '${TRANSLATE} -pso ${SOURCES} -o ${TARGET}')
 
 
@@ -43,7 +43,8 @@ def MakeAndTranslatePso(dest, bitcode_file, llvm_passes):
       '-verify-pnaclabi-module -verify-pnaclabi-functions '
       '-pnaclabi-allow-debug-metadata '
       '${SOURCES} -o ${TARGET}')
-  return FinalizeAndTranslatePso(dest, opt_result)
+  finalized_result = FinalizePso(dest, opt_result)
+  return TranslatePso(dest, finalized_result)
 
 def PsoFromLLVMAssembly(base_name):
   bitcode_file = env.Command(
@@ -54,11 +55,24 @@ def PsoFromLLVMAssembly(base_name):
                              llvm_passes='')
 
 
-def MakeAndTranslatePll(dest, source_file):
+def MakePll(dest, source_file, dependencies):
+  deps = ''
+  if dependencies != []:

[Mark Seaborn, 2016/03/30 23:24:57]

"len(dependencies) != 0" is arguably more idiomatic in Python since it works for
any iterable type.

Or you could make this unconditional.

[Sean Klein, 2016/04/01 23:12:25]

Using "len(dependencies) != 0"

+    deps += ' -L' + Dir('.').abspath
+  for d in dependencies:
+    deps += ' -l:' + d[0].name
   nonfinal_pll = env.Command(
       dest + '.nonfinal.pll', [source_file],
-      '${CC} -shared ${SOURCES} -o ${TARGET}')
-  return FinalizeAndTranslatePso(dest, nonfinal_pll)
+      '${CC} -shared ${SOURCES} -o ${TARGET}' + deps)
+  for d in dependencies:

[Mark Seaborn, 2016/03/30 23:24:57]

I think you can do
Depends(nonfinal_pll, dependencies)
for brevity

[Sean Klein, 2016/04/01 23:12:25]

Done.

+    # Linking the nonfinal_pll depends on the untranslated, finalized PLL (.so)
+    # dependencies existing.
+    Depends(nonfinal_pll, d)
+  return FinalizePso(dest, nonfinal_pll)
+
+def MakeAndTranslatePll(dest, source_file, dependencies):
+  finalized_pll = MakePll(dest, source_file, dependencies)
+  return TranslatePso(dest, finalized_pll)
 
 # Under SFI NaCl, the loader currently depends on the allocate_code_data()
 # interface provided by the IRT.
@@ -96,8 +110,7 @@ test_pll = MakeAndTranslatePso(
     '-rewrite-pnacl-library-calls -rewrite-llvm-intrinsic-calls '
     '-convert-to-pso -convert-to-pso-deps=libfoo.so,libbar.so '
     '-pnacl-abi-simplify-postopt')
-
-test_pll_tls = MakeAndTranslatePll('test_pll_tls', 'test_pll_tls.c')
+test_pll_tls = MakeAndTranslatePll('test_pll_tls', 'test_pll_tls.c', [])
 
 pll_symbols_test = env.ComponentProgram(
     'pll_symbols_test', ['pll_symbols_test.cc'],
@@ -112,8 +125,11 @@ env.AddNodeToTestSuite(
     'run_pll_symbols_test', is_broken=is_broken)
 
 
-test_pll_a = MakeAndTranslatePll('test_pll_a', 'test_pll_a.c')
-test_pll_b = MakeAndTranslatePll('test_pll_b', 'test_pll_b.c')
+test_pll_a_finalized = MakePll('test_pll_a', 'test_pll_a.c', [])
+test_pll_a = TranslatePso('test_pll_a', test_pll_a_finalized)
+test_pll_b_finalized = MakePll('test_pll_b', 'test_pll_b.c',
+                               [test_pll_a_finalized])
+test_pll_b = TranslatePso('test_pll_b', test_pll_b_finalized)
 
 pll_loader_test = env.ComponentProgram(
     'pll_loader_test', ['pll_loader_test.cc'],
@@ -130,7 +146,7 @@ env.AddNodeToTestSuite(
     'run_pll_loader_test', is_broken=is_broken)
 
 
-pll_libc = env.Command(
+pll_libc_nonfinal = env.Command(
     'libc${OBJSUFFIX}',
     # libnacl should come first so that it can override definitions in libc.
     [env.File('${LIB_DIR}/libnacl.a'),
@@ -138,10 +154,13 @@ pll_libc = env.Command(
      env.ComponentObject('libc_entry.c')],
     '${CC} -shared -Wl,--whole-archive ${SOURCES} -o ${TARGET}')
 
-translated_pll_libc = FinalizeAndTranslatePso('translated_pll_libc', pll_libc)
-translated_pll_hello_world = MakeAndTranslatePll(
-    'translated_pll_hello_world',
-    '../hello_world/hello_world.c')
+pll_libc_finalized = FinalizePso('pll_libc', pll_libc_nonfinal)
+pll_libc = TranslatePso('pll_libc', pll_libc_finalized)
+
+pll_hello_world = MakeAndTranslatePll(
+    'pll_hello_world',
+    '../hello_world/hello_world.c',
+    [pll_libc_finalized])
 
 # Ideally we would have this ComponentProgram() definition in
 # src/untrusted/pll_loader/nacl.scons instead; see the comment there for
@@ -152,10 +171,31 @@ pll_loader = env.ComponentProgram(
 
 node = env.CommandSelLdrTestNacl(
     'pll_hello_world_test.out', pll_loader,
-    [translated_pll_libc, translated_pll_hello_world],
+    [Dir('.').abspath, 'pll_hello_world.so'],
     # Add '-a' to enable filesystem access for opening DSOs.
     sel_ldr_flags=['-a'],
-    stdout_golden=env.File('../hello_world/hello_world.stdout'))
+    stdout_golden=env.File('../hello_world/hello_world.stdout'),
+    extra_deps=[pll_libc, pll_hello_world])
 env.AddNodeToTestSuite(
     node, ['small_tests', 'toolchain_tests'],
     'run_pll_hello_world_test', is_broken=is_broken)
+
+
+test_pll_c_finalized = MakePll(
+    'test_pll_c', 'test_pll_c.c', [test_pll_a_finalized, test_pll_b_finalized])
+test_pll_c = TranslatePso('test_pll_c', test_pll_c_finalized)
+
+pll_dependencies_test = MakeAndTranslatePll(
+    'pll_dependencies_test', 'dependencies_test.c',
+    [pll_libc_finalized, test_pll_c_finalized])
+
+node = env.CommandSelLdrTestNacl(
+    'pll_dependencies_test.out', pll_loader,
+    [Dir('.').abspath, 'pll_dependencies_test.so'],
+    # Add '-a' to enable filesystem access for opening DSOs.
+    sel_ldr_flags=['-a'], stdout_golden=env.File('dependencies_test.stdout'),
+    extra_deps=[pll_libc, test_pll_a, test_pll_b, test_pll_c,
+    pll_dependencies_test])

[Mark Seaborn, 2016/03/30 23:24:57]

Nit: indent to align with "["

[Sean Klein, 2016/04/01 23:12:25]

Done.

+env.AddNodeToTestSuite(
+    node, ['small_tests', 'toolchain_tests'], 'run_pll_dependencies_test',
+    is_broken=is_broken)