src/untrusted/pll_loader/pll_loader_main.cc - Issue 1825893002: PNaCl Dynamic Linking: Added portable dependencies to shared objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/untrusted/pll_loader/pll_loader_main.cc

Issue 1825893002: PNaCl Dynamic Linking: Added portable dependencies to shared objects. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/untrusted/pll_loader/pll_loader.cc ('K') | « src/untrusted/pll_loader/pll_loader.cc ('k') | src/untrusted/pll_loader/pll_root.h » ('j') | tests/pnacl_dynamic_loading/dependencies_test.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/untrusted/pll_loader/pll_loader_main.cc

diff --git a/src/untrusted/pll_loader/pll_loader_main.cc b/src/untrusted/pll_loader/pll_loader_main.cc

index 2a489bd8e6c7263d7d53bfe2a0340f8e4fd37570..2095b4988f465cca884a1e4a904aa56ae1a86517 100644

--- a/src/untrusted/pll_loader/pll_loader_main.cc

+++ b/src/untrusted/pll_loader/pll_loader_main.cc

@@ -15,10 +15,8 @@ typedef void (*start_func_t)(int argc, char **argv, char **envp,

Elf32_auxv_t *auxv);

int main(int argc, char **argv, char **envp) {

- // The PLL format does not include module dependencies yet, so all the

- // modules must be specified on the command line.

- if (argc <= 2) {

- fprintf(stderr, "Usage: pll_loader <ELF file>...\n");

+ if (argc != 2) {

+ fprintf(stderr, "Usage: pll_loader <ELF file>\n");

return 1;

}