Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2118)

Unified Diff: pnacl/driver/filetype.py

Issue 1825893002: PNaCl Dynamic Linking: Added portable dependencies to shared objects. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pnacl/driver/filetype.py
diff --git a/pnacl/driver/filetype.py b/pnacl/driver/filetype.py
index 898c023dffdf3127cfb250f42d2dee3fa43bd013..2732b7cdedaf30eb040bc176c8de17be5a77ee87 100644
--- a/pnacl/driver/filetype.py
+++ b/pnacl/driver/filetype.py
@@ -67,6 +67,10 @@ def IsNativeDSO(filename):
return FileType(filename) == 'so'
@SimpleCache
+def IsPll(filename):
+ return FileType(filename) == 'pll'
+
+@SimpleCache
def GetBitcodeMagic(filename):
fp = driver_log.DriverOpen(filename, 'rb')
header = fp.read(4)
@@ -349,6 +353,10 @@ def FileType(filename):
return 'po'
if IsPNaClBitcode(filename):
+ # Although this file looks like a native ".so", it actually is in a
Mark Seaborn 2016/03/30 23:24:57 "looks like" -> "has the same extension as"?
Sean Klein 2016/04/01 23:12:24 Done.
+ # portable format and should be handled slightly differently.
+ if ext == 'so':
+ return 'pll'
return 'pexe'
if IsLinkerScript(filename):
« no previous file with comments | « pnacl/build.sh ('k') | pnacl/driver/pnacl-ld.py » ('j') | pnacl/driver/pnacl-ld.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698