Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1825863002:
Allow windows to use both 100P, 200P assets (Closed)
DescriptionAllow windows to use both 100P, 200P assets
Theme may use the wrong assets when deviceScaleFactor/devicePixelRatio changes without this change.
BUG=561183, 596038
Committed: https://crrev.com/cb8feac7b8a21a9e63b9d20ad58d5a8121c28fb2
Cr-Commit-Position: refs/heads/master@{#384114}
Patch Set 1 : #
Total comments: 1
Patch Set 2 : fixed edit miss #Messages
Total messages: 29 (16 generated)
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Description was changed from ========== Use allow 100P / 200P assets on Windows BUG=561183,596038 ========== to ========== Allow windows to use both 100P, 200P assets Theme may use the wrong assets when deviceScaleFactor/devicePixelRatio changes. BUG=561183,596038 ==========
oshima@chromium.org changed reviewers: + sky@chromium.org
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Description was changed from ========== Allow windows to use both 100P, 200P assets Theme may use the wrong assets when deviceScaleFactor/devicePixelRatio changes. BUG=561183,596038 ========== to ========== Allow windows to use both 100P, 200P assets Theme can use the wrong assets when deviceScaleFactor/devicePixelRatio changes. BUG=561183,596038 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825863002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825863002/60001
https://codereview.chromium.org/1825863002/diff/60001/ui/base/resource/resour... File ui/base/resource/resource_bundle.cc (left): https://codereview.chromium.org/1825863002/diff/60001/ui/base/resource/resour... ui/base/resource/resource_bundle.cc:684: // percent. ImageSkia uses 2.0 assets for 1.25 so this is no longer an issue.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825863002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825863002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Allow windows to use both 100P, 200P assets Theme can use the wrong assets when deviceScaleFactor/devicePixelRatio changes. BUG=561183,596038 ========== to ========== Allow windows to use both 100P, 200P assets Theme may use the wrong assets when deviceScaleFactor/devicePixelRatio changes without this change. BUG=561183,596038 ==========
LGTM
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825863002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825863002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825863002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825863002/80001
Message was sent while issue was closed.
Description was changed from ========== Allow windows to use both 100P, 200P assets Theme may use the wrong assets when deviceScaleFactor/devicePixelRatio changes without this change. BUG=561183,596038 ========== to ========== Allow windows to use both 100P, 200P assets Theme may use the wrong assets when deviceScaleFactor/devicePixelRatio changes without this change. BUG=561183,596038 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Allow windows to use both 100P, 200P assets Theme may use the wrong assets when deviceScaleFactor/devicePixelRatio changes without this change. BUG=561183,596038 ========== to ========== Allow windows to use both 100P, 200P assets Theme may use the wrong assets when deviceScaleFactor/devicePixelRatio changes without this change. BUG=561183,596038 Committed: https://crrev.com/cb8feac7b8a21a9e63b9d20ad58d5a8121c28fb2 Cr-Commit-Position: refs/heads/master@{#384114} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/cb8feac7b8a21a9e63b9d20ad58d5a8121c28fb2 Cr-Commit-Position: refs/heads/master@{#384114} |
