Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1825843002: Support multi-arg fast push support (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support multi-arg fast push support Deoptimizing from the stub is fairly slow, so add support for the other fast-path cases to avoid deopts. Notably, push with multi-arg is used by pdfjs. BUG=chromium:597252 LOG=n Committed: https://crrev.com/dc6b7855c45eeddf58a0a81b1ccd7e5c54ab55c7 Cr-Commit-Position: refs/heads/master@{#35037}

Patch Set 1 #

Patch Set 2 : Return new-length #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -29 lines) Patch
M src/code-stubs-hydrogen.cc View 1 6 chunks +44 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-23 15:22:34 UTC) #2
Camillo Bruni
lgtm
4 years, 9 months ago (2016-03-23 15:40:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825843002/20001
4 years, 9 months ago (2016-03-23 15:40:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15721)
4 years, 9 months ago (2016-03-23 16:02:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825843002/20001
4 years, 9 months ago (2016-03-23 16:15:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 16:26:22 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 16:26:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc6b7855c45eeddf58a0a81b1ccd7e5c54ab55c7
Cr-Commit-Position: refs/heads/master@{#35037}

Powered by Google App Engine
This is Rietveld 408576698