Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 182583002: Revert of Add template parameter to ElementTraversal to iterate over Elements of a specific type (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, adamk
Visibility:
Public.

Description

Revert of Add template parameter to ElementTraversal to iterate over Elements of a specific type (https://codereview.chromium.org/179333004/) Reason for revert: Does not work as intended, I noticed breakages when porting more code to the new API. Reverting until I figure out the problem. Original issue's description: > Add template parameter to ElementTraversal to iterate over Elements of a specific type > > Add template parameter to ElementTraversal to iterate over Elements of a > specific type. The resulting code looks like: > HTMLTableRowElement* row = Traversal<HTMLTableRowElement>::firstWithin(table); > > This avoids having to traverse generic Elements and then explicitly check their > tag name to make sure it is a specific Element subclass. > > This CL only updates one file to use this functionality. The rest of the code > will be ported in a follow-up patch to reduce patch size. > > This patch is based on the following WebKit revision by <antti@apple.com>;: > http://trac.webkit.org/changeset/154481 > > R=esprehn@chromium.org, eseidel, esprehn > BUG=346733 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167945 TBR=eseidel@chromium.org,esprehn@chromium.org NOTREECHECKS=true NOTRY=true BUG=346733 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -219 lines) Patch
M Source/build/scripts/templates/ElementTypeHelpers.h.tmpl View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -23 lines 0 comments Download
M Source/core/dom/ElementTraversal.h View 1 chunk +61 lines, -76 lines 0 comments Download
M Source/core/dom/NodeIterator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/dom/NodeIteratorBase.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/core/dom/NodeIteratorBase.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
A Source/core/dom/Traversal.h View 1 chunk +58 lines, -0 lines 0 comments Download
A Source/core/dom/Traversal.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
M Source/core/dom/TreeWalker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/TreeWalker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableRowsCollection.cpp View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Inactive
Created Revert of Add template parameter to ElementTraversal to iterate over Elements of a specific ...
6 years, 10 months ago (2014-02-27 02:04:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/182583002/1
6 years, 10 months ago (2014-02-27 02:05:39 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-27 02:06:39 UTC) #3
Message was sent while issue was closed.
Change committed as 167956

Powered by Google App Engine
This is Rietveld 408576698