Cleanup: LFH only needs to be enabled on XP/2003

base/allocator/allocator_shim_win.cc

Index: base/allocator/allocator_shim_win.cc
diff --git a/base/allocator/allocator_shim_win.cc b/base/allocator/allocator_shim_win.cc
index b65544f5dd89ad00db76f36f894347a8506e76df..2549c312edc2a8b7c3d545f6d2589733c0219df1 100644
--- a/base/allocator/allocator_shim_win.cc
+++ b/base/allocator/allocator_shim_win.cc
@@ -44,17 +44,7 @@ bool win_heap_init() {
   // Set the _crtheap global here.  THis allows us to offload most of the
   // memory management to the CRT, except the functions we need to shim.
   _crtheap = GetProcessHeap();
-  if (_crtheap == NULL)

[Will Harris, 2016/03/30 22:36:36]

this code is already going with the move to VS2015...

can you include base/allocator owners on changes in allocator rather than going
up to base/ thanks!

[manzagop (departed), 2016/03/31 13:04:45]

Sorry, I wasn't sure how to tradeoff reviewer count/specificity (I already
needed a base/ reviewer for base/process which doesn't have an owners, and this
seemed harmless). 

Thanks for the heads up, will adjust!

-    return false;
-
-  ULONG enable_lfh = 2;
-  // NOTE: Setting LFH may fail.  Vista already has it enabled.
-  //       And under the debugger, it won't use LFH.  So we
-  //       ignore any errors.
-  HeapSetInformation(_crtheap, HeapCompatibilityInformation, &enable_lfh,
-                     sizeof(enable_lfh));
-
-  return true;
+  return _crtheap != nullptr;
 }
 
 void* win_heap_malloc(size_t size) {