Cleanup: LFH only needs to be enabled on XP/2003

base/allocator/allocator_shim_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>
 #include <malloc.h>
 #include <new.h>
 #include <windows.h>
 #include <stddef.h>
 
@@ skipping 26 matching lines @@
 const size_t kWindowsPageSize = 4096;
 const size_t kMaxWindowsAllocation = INT_MAX - kWindowsPageSize;
 int new_mode = 0;
 
 // VS2013 crt uses the process heap as its heap, so we do the same here.
 // See heapinit.c in VS CRT sources.
 bool win_heap_init() {
   // Set the _crtheap global here.  THis allows us to offload most of the
   // memory management to the CRT, except the functions we need to shim.
   _crtheap = GetProcessHeap();
-  if (_crtheap == NULL)
-    return false;
-
-  ULONG enable_lfh = 2;
-  // NOTE: Setting LFH may fail.  Vista already has it enabled.
-  //       And under the debugger, it won't use LFH.  So we
-  //       ignore any errors.
-  HeapSetInformation(_crtheap, HeapCompatibilityInformation, &enable_lfh,
-                     sizeof(enable_lfh));
-
-  return true;
+  return _crtheap != NULL;

[scottmg, 2016/03/29 20:23:32]

NULL -> nullptr

[manzagop (departed), 2016/03/29 20:35:04]

Done.

 }
 
 void* win_heap_malloc(size_t size) {
   if (size < kMaxWindowsAllocation)
     return HeapAlloc(_crtheap, 0, size);
   return NULL;
 }
 
 void win_heap_free(void* size) {
   HeapFree(_crtheap, 0, size);
@@ skipping 252 matching lines @@
 void _free_dbg(void* ptr, int) {
   free(ptr);
 }
 
 void* _calloc_dbg(size_t n, size_t size, int, const char*, int) {
   return calloc(n, size);
 }
 #endif  // NDEBUG
 
 }  // extern C