Issue 18258012: [Android] Some clean up around gtest packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18258012: [Android] Some clean up around gtest packages. (Closed)

Created:
7 years, 5 months ago by frankf

Modified:
7 years, 5 months ago

Reviewers:
craigdh

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Some clean up around gtest packages. Clarify the concepts of test_runner versus test_package. BUG= NOTRY=True R=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211860

Patch Set 3 : Rebased #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -389 lines)			Patch
M	build/android/pylib/base/base_test_runner.py	View		3 chunks	+8 lines, -7 lines	0 comments	Download
M	build/android/pylib/gtest/dispatch.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/gtest/test_package.py	View	1	5 chunks	+31 lines, -97 lines	0 comments	Download
M	build/android/pylib/gtest/test_package_apk.py	View	1	5 chunks	+50 lines, -47 lines	0 comments	Download
A +	build/android/pylib/gtest/test_package_exe.py	View	1	4 chunks	+24 lines, -37 lines	0 comments	Download
M	build/android/pylib/gtest/test_package_executable.py	View		1 chunk	+0 lines, -167 lines	0 comments	Download
M	build/android/pylib/gtest/test_runner.py	View	1 2	7 chunks	+111 lines, -31 lines	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

craigdh

Nice cleanup. lgtm. https://codereview.chromium.org/18258012/diff/8001/build/android/pylib/gtest/test_package.py File build/android/pylib/gtest/test_package.py (right): https://codereview.chromium.org/18258012/diff/8001/build/android/pylib/gtest/test_package.py#newcode36 build/android/pylib/gtest/test_package.py:36: def CreateTestRunnerScript(self, test_filter, test_arguments): weird name. ...

7 years, 5 months ago (2013-07-16 18:36:47 UTC) #2

frankf

7 years, 5 months ago (2013-07-16 22:06:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r211860 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18258012: [Android] Some clean up around gtest packages. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : Fixed comment #

Patch Set 3 : Rebased #

Messages