[stubs] Introduce code stubs for bitwise binary operations.

[stubs] Introduce code stubs for bitwise binary operations.

Add BitwiseAndStub, BitwiseOrStub and BitwiseXorStub, and hook them up
with Ignition and TurboFan.

R=epertoso@chromium.org

Committed: https://crrev.com/db18219e4b8b1af73b31e6f3481b0fefa1d20954
Cr-Commit-Position: refs/heads/master@{#35029}

[Benedikt Meurer, 2016-03-23 11:24:02]

Description was changed from

==========
[stubs] Introduce code stubs for bitwise binary operations.

Add BitwiseAndStub, BitwiseOrStub and BitwiseXorStub, and hook them up
with Ignition and TurboFan.
==========

to

==========
[stubs] Introduce code stubs for bitwise binary operations.

Add BitwiseAndStub, BitwiseOrStub and BitwiseXorStub, and hook them up
with Ignition and TurboFan.

R=epertoso@chromium.org
==========

[Benedikt Meurer, 2016-03-23 11:24:02]

bmeurer@chromium.org changed reviewers:
+ epertoso@chromium.org

[Benedikt Meurer, 2016-03-23 11:24:48]

Hey Enrico,

Another bunch of spec operations.
Please take a look.

Thanks,
Benedikt

[epertoso, 2016-03-23 13:15:39]

https://codereview.chromium.org/1825793002/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1825793002/diff/1/src/code-stubs.cc#newcode1060
src/code-stubs.cc:1060: assembler->Goto(&loop);
Wouldn't an 'ObjectToInt32' or similar-named method, to be called for each of
the values, actually make this stub slightly more readable?

[Benedikt Meurer, 2016-03-23 13:23:03]

https://codereview.chromium.org/1825793002/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1825793002/diff/1/src/code-stubs.cc#newcode1060
src/code-stubs.cc:1060: assembler->Goto(&loop);
Well, you'd still need to distinguish HeapNumber and Smi then for both sides,
which ObjectToInt32 already checks. So you'd make it slower and only slightly
more readable.

[epertoso, 2016-03-23 13:41:39]

lgtm

https://codereview.chromium.org/1825793002/diff/1/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1825793002/diff/1/src/code-stubs.cc#newcode1060
src/code-stubs.cc:1060: assembler->Goto(&loop);
On 2016/03/23 at 13:23:03, Benedikt Meurer wrote:
> Well, you'd still need to distinguish HeapNumber and Smi then for both sides,
which ObjectToInt32 already checks. So you'd make it slower and only slightly
more readable.

As discussed offline, let's leave it like this for now.

[Benedikt Meurer, 2016-03-23 13:42:29]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-03-23 13:42:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825793002/1

[commit-bot: I haz the power, 2016-03-23 13:44:39]

Description was changed from

==========
[stubs] Introduce code stubs for bitwise binary operations.

Add BitwiseAndStub, BitwiseOrStub and BitwiseXorStub, and hook them up
with Ignition and TurboFan.

R=epertoso@chromium.org
==========

to

==========
[stubs] Introduce code stubs for bitwise binary operations.

Add BitwiseAndStub, BitwiseOrStub and BitwiseXorStub, and hook them up
with Ignition and TurboFan.

R=epertoso@chromium.org
==========

[commit-bot: I haz the power, 2016-03-23 13:44:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-23 13:45:03]

Description was changed from

==========
[stubs] Introduce code stubs for bitwise binary operations.

Add BitwiseAndStub, BitwiseOrStub and BitwiseXorStub, and hook them up
with Ignition and TurboFan.

R=epertoso@chromium.org
==========

to

==========
[stubs] Introduce code stubs for bitwise binary operations.

Add BitwiseAndStub, BitwiseOrStub and BitwiseXorStub, and hook them up
with Ignition and TurboFan.

R=epertoso@chromium.org

Committed: https://crrev.com/db18219e4b8b1af73b31e6f3481b0fefa1d20954
Cr-Commit-Position: refs/heads/master@{#35029}
==========

[commit-bot: I haz the power, 2016-03-23 13:45:04]

Patchset 1 (id:??) landed as
https://crrev.com/db18219e4b8b1af73b31e6f3481b0fefa1d20954
Cr-Commit-Position: refs/heads/master@{#35029}