Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1825733003: Stop chrome from initializing ozone inside mash. (Closed)

Created:
4 years, 9 months ago by kylechar
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, rjkroege, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop chrome from initializing ozone inside mash. The chrome UI process normally initializes ozone. When running inside mash the mus prcoess owns ozone instead. Add a check for a flag that signals chrome is running inside mash and don't initialize ozone in that case. BUG=592756 Committed: https://crrev.com/4ed171b7b7cf88fea577208abbe901a125f675dc Cr-Commit-Position: refs/heads/master@{#382894}

Patch Set 1 #

Patch Set 2 : Fix unused with #ifdef. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M ui/aura/env.cc View 1 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
kylechar
4 years, 9 months ago (2016-03-23 13:27:15 UTC) #2
sky
LGTM
4 years, 9 months ago (2016-03-23 15:32:03 UTC) #3
kylechar
Thanks sky!
4 years, 9 months ago (2016-03-23 15:34:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825733003/1
4 years, 9 months ago (2016-03-23 15:35:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/176504)
4 years, 9 months ago (2016-03-23 15:47:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825733003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825733003/20001
4 years, 9 months ago (2016-03-23 18:11:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 18:56:45 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 18:57:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ed171b7b7cf88fea577208abbe901a125f675dc
Cr-Commit-Position: refs/heads/master@{#382894}

Powered by Google App Engine
This is Rietveld 408576698