Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Issue 1825603003: Reland of move configuration policy from chrome build files. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@policy_chrome_defines
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of move configuration policy from chrome build files. (patchset #1 id:1 of https://codereview.chromium.org/1818423003/ ) Reason for revert: Reland original patch, it was not the cause Original issue's description: > Revert of Remove configuration policy from chrome build files. (patchset #4 id:60001 of https://codereview.chromium.org/1798273002/ ) > > Reason for revert: > Speculative revert: could have caused the Win8 GN build failures. See crbug.com/597032 > > Original issue's description: > > Remove configuration policy from chrome build files. > > > > The define was removed from src/chrome source files in https://codereview.chromium.org/1786263002/, this patch only touches the build files in src/chrome. Build updates outside of this directory will be updated in subsequent passes. > > > > BUG=594261 > > > > Committed: https://crrev.com/db234c06ff6c308520594591fa54f80b08411888 > > Cr-Commit-Position: refs/heads/master@{#382614} > > TBR=atwilson@chromium.org,brettw@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=594261 > > Committed: https://crrev.com/e742862f9555579e3239d9658766081ac4729e92 > Cr-Commit-Position: refs/heads/master@{#382681} TBR=atwilson@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594261 Committed: https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076 Cr-Commit-Position: refs/heads/master@{#382689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -462 lines) Patch
M chrome/BUILD.gn View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/AndroidManifest.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/BUILD.gn View 4 chunks +12 lines, -44 lines 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/policy/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/policy/profile_policy_connector_stub.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/chrome.gyp View 4 chunks +3 lines, -9 lines 0 comments Download
M chrome/chrome_browser.gypi View 11 chunks +60 lines, -107 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 5 chunks +7 lines, -16 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 4 chunks +7 lines, -14 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/chrome_dll.gypi View 3 chunks +4 lines, -14 lines 0 comments Download
M chrome/chrome_exe.gypi View 4 chunks +2 lines, -14 lines 0 comments Download
M chrome/chrome_process_finder.gypi View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 6 chunks +16 lines, -27 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 17 chunks +25 lines, -60 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/policy.gypi View 1 chunk +19 lines, -23 lines 0 comments Download
M chrome/test/BUILD.gn View 8 chunks +11 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dgozman
Created Reland of move configuration policy from chrome build files.
4 years, 9 months ago (2016-03-22 21:43:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825603003/1
4 years, 9 months ago (2016-03-22 21:44:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 21:45:23 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 21:47:46 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5a3e25d653b7de06a9c9c90e589265a57e17076
Cr-Commit-Position: refs/heads/master@{#382689}

Powered by Google App Engine
This is Rietveld 408576698