Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1825603002: Revert "Add graph intrinsics for many math library functions" (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add graph intrinsics for many math library functions" This reverts commit f5bc8fa353772bb66537cc2862f7f4b0a3f6cfbb. BUG= Committed: https://github.com/dart-lang/sdk/commit/1e0abf4df01ae1d3703ef9222f9250ab5649793d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -216 lines) Patch
M runtime/vm/intermediate_language.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 13 chunks +15 lines, -201 lines 0 comments Download
M runtime/vm/method_recognizer.h View 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
Committed patchset #1 (id:1) manually as 1e0abf4df01ae1d3703ef9222f9250ab5649793d (presubmit successful).
4 years, 9 months ago (2016-03-22 19:45:52 UTC) #2
Cutch
Reverting while I investigate failures related to calling C from intrinsics.
4 years, 9 months ago (2016-03-22 19:46:25 UTC) #5
Florian Schneider
4 years, 9 months ago (2016-03-22 22:22:55 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698