Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1825593003: S390: [stubs] Split ToNumberStub into reusable subparts. (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [stubs] Split ToNumberStub into reusable subparts. Port b7aa4c3ab35b3a28fee7fc49bf7aa1003d66959e Original commit message: Split ToNumberStub into the entry ToNumberStub, and two new stubs, StringToNumberStub and NonNumberToNumberStub, which can be used when we already know something about the input (i.e. in various branches of the code stubs, or in TurboFan graphs). Also introduce an appropriate StringToNumber simplified operator for TurboFan, that is pure and is lowered to an invocation of the newly added StringToNumberStub. R=bmeurer@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/0503ba760fbc90e759a79592ee02ddc3029e104d Cr-Commit-Position: refs/heads/master@{#35004}

Patch Set 1 : PS1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -17 lines) Patch
M src/s390/code-stubs-s390.cc View 3 chunks +33 lines, -17 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +12 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825593003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825593003/40001
4 years, 9 months ago (2016-03-22 19:39:52 UTC) #4
john.yan
PTAL
4 years, 9 months ago (2016-03-22 19:39:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 19:58:03 UTC) #7
JoranSiu
lgtm https://codereview.chromium.org/1825593003/diff/40001/src/s390/macro-assembler-s390.cc File src/s390/macro-assembler-s390.cc (right): https://codereview.chromium.org/1825593003/diff/40001/src/s390/macro-assembler-s390.cc#newcode2932 src/s390/macro-assembler-s390.cc:2932: Check(ne, kOperandIsANumber, cr0); We probably should clean up ...
4 years, 9 months ago (2016-03-22 20:05:59 UTC) #8
john.yan
On 2016/03/22 20:05:59, JoranSiu wrote: > lgtm > > https://codereview.chromium.org/1825593003/diff/40001/src/s390/macro-assembler-s390.cc > File src/s390/macro-assembler-s390.cc (right): > ...
4 years, 9 months ago (2016-03-22 20:07:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825593003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825593003/40001
4 years, 9 months ago (2016-03-22 20:08:00 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 9 months ago (2016-03-22 20:10:05 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 20:11:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0503ba760fbc90e759a79592ee02ddc3029e104d
Cr-Commit-Position: refs/heads/master@{#35004}

Powered by Google App Engine
This is Rietveld 408576698