GrVkGpu initialization cleanup.

src/gpu/vk/GrVkGpu.h

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrVkGpu_DEFINED
 #define GrVkGpu_DEFINED
 
 #include "GrGpu.h"
 #include "GrGpuFactory.h"
+#include "vk/GrVkBackendContext.h"
 #include "GrVkCaps.h"
 #include "GrVkIndexBuffer.h"
 #include "GrVkProgram.h"
 #include "GrVkResourceProvider.h"
 #include "GrVkVertexBuffer.h"
 #include "GrVkUtil.h"
 
 #include "shaderc/shaderc.h"
 #include "vulkan/vulkan.h"
 
 class GrPipeline;
 class GrNonInstancedMesh;
 
 class GrVkBufferImpl;
 class GrVkCommandBuffer;
 class GrVkPipeline;
 class GrVkRenderPass;
 class GrVkTexture;
 struct GrVkInterface;
 
 #ifdef SK_DEBUG
 #define ENABLE_VK_LAYERS
 #endif
 
 class GrVkGpu : public GrGpu {
 public:
-    // Currently passing in the inst so that we can properly delete it when we are done.
-    // Normally this would be done by the client.
-    GrVkGpu(GrContext* context, const GrContextOptions& options,
-            VkPhysicalDevice physDev, VkDevice device, VkQueue queue, VkCommandPool cmdPool,
-            VkInstance inst);
+    static GrGpu* Create(GrBackendContext backendContext, const GrContextOptions& options,
+                         GrContext* context);
+
     ~GrVkGpu() override;
 
-    const GrVkInterface* vkInterface() const { return fInterface.get(); }
+    const GrVkInterface* vkInterface() const { return fBackendContext->fInterface; }
     const GrVkCaps& vkCaps() const { return *fVkCaps; }
 
     VkDevice device() const { return fDevice; }
     VkQueue  queue() const { return fQueue; }
     VkCommandPool cmdPool() const { return fCmdPool; }
     VkPhysicalDeviceMemoryProperties physicalDeviceMemoryProperties() const {
         return fPhysDevMemProps;
     }
 
     GrVkResourceProvider& resourceProvider() { return fResourceProvider;  }
@@ skipping 60 matching lines @@
                                bool byRegion,
                                VkImageMemoryBarrier* barrier) const;
     
     shaderc_compiler_t shadercCompiler() const {
         return fCompiler;
     }
 
     void finishDrawTarget() override;
 
 private:
+    GrVkGpu(GrContext* context, const GrContextOptions& options,
+            const GrVkBackendContext* backendContext);
+
     void onResetContext(uint32_t resetBits) override {}
 
     GrTexture* onCreateTexture(const GrSurfaceDesc& desc, GrGpuResource::LifeCycle,
                                const SkTArray<GrMipLevel>&) override;
 
     GrTexture* onCreateCompressedTexture(const GrSurfaceDesc& desc, GrGpuResource::LifeCycle,
                                          const SkTArray<GrMipLevel>&) override {
         SkDebugf("onCreateCompressedTexture not yet implemented for Vulkan\n");
         return NULL;
     }
@@ skipping 67 matching lines @@
                            const SkIRect& srcRect,
                            const SkIPoint& dstPoint);
 
     // helper for onCreateTexture and writeTexturePixels
     bool uploadTexData(GrVkTexture* tex,
                        int left, int top, int width, int height,
                        GrPixelConfig dataConfig,
                        const void* data,
                        size_t rowBytes);
 
-    SkAutoTUnref<const GrVkInterface> fInterface;
-    SkAutoTUnref<GrVkCaps>            fVkCaps;
-    VkPhysicalDeviceMemoryProperties  fPhysDevMemProps;
-    VkDevice                          fDevice;
-    VkQueue                           fQueue;   // for now, one queue
-    VkCommandPool                     fCmdPool;
-    GrVkCommandBuffer*                fCurrentCmdBuffer;
-    GrVkResourceProvider              fResourceProvider;
+    SkAutoTUnref<const GrVkBackendContext> fBackendContext;
+    SkAutoTUnref<GrVkCaps>                 fVkCaps;
+
+    // These Vulkan objects are provided by the client, and also stored in fBackendContext.
+    // They're copied here for convenient access.
+    VkInstance                             fVkInstance;
+    VkDevice                               fDevice;
+    VkQueue                                fQueue;    // Must be Graphics queue
+
+    // Created by GrVkGpu
+    GrVkResourceProvider                   fResourceProvider;
+    VkCommandPool                          fCmdPool;
+    GrVkCommandBuffer*                     fCurrentCmdBuffer;
+    VkPhysicalDeviceMemoryProperties       fPhysDevMemProps;
 
 #ifdef ENABLE_VK_LAYERS
     // For reporting validation layer errors
-    VkDebugReportCallbackEXT          fCallback;
+    VkDebugReportCallbackEXT               fCallback;
 #endif
 
     // Shaderc compiler used for compiling glsl in spirv. We only want to create the compiler once
     // since there is significant overhead to the first compile of any compiler.
     shaderc_compiler_t fCompiler;
 
-    // This is only for our current testing and building. The client should be holding on to the
-    // VkInstance.
-    VkInstance                        fVkInstance;
 
     typedef GrGpu INHERITED;
 };
 
 #endif