Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1825533002: Navigation start to commit trace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 41f1221c55b6bc580a68e60876c641895b3a35d5..1a29e18a5ca51c687c42f46740f415fc611f4b65 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -287,7 +287,7 @@ bool NavigatorImpl::NavigateToEntry(
frame_tree_node->navigation_request()) {
// TODO(carlosk): extend these traces to support subframes and
// non-PlzNavigate navigations.
- // For these traces below we're using the navigation handle as the async
+ // For the trace below we're using the navigation handle as the async
// trace id, |navigation_start| as the timestamp and reporting the
// FrameTreeNode id as a parameter. For navigations where no network
// request is made (data URLs, JavaScript URLs, etc) there is no handle
@@ -297,11 +297,6 @@ bool NavigatorImpl::NavigateToEntry(
frame_tree_node->navigation_request()->navigation_handle(),
navigation_start.ToInternalValue(),
"FrameTreeNode id", frame_tree_node->frame_tree_node_id());
- TRACE_EVENT_ASYNC_BEGIN_WITH_TIMESTAMP1(
- "navigation", "Navigation timeToCommit",
- frame_tree_node->navigation_request()->navigation_handle(),
- navigation_start.ToInternalValue(),
- "FrameTreeNode id", frame_tree_node->frame_tree_node_id());
}
} else {
@@ -539,12 +534,6 @@ void NavigatorImpl::DidNavigate(
if (!params.url_is_unreachable)
render_frame_host->set_last_successful_url(params.url);
- if (did_navigate && render_frame_host->frame_tree_node()->IsMainFrame() &&
- IsBrowserSideNavigationEnabled()) {
- TRACE_EVENT_ASYNC_END0("navigation", "Navigation timeToCommit",
- render_frame_host->navigation_handle());
- }
-
// Send notification about committed provisional loads. This notification is
// different from the NAV_ENTRY_COMMITTED notification which doesn't include
// the actual URL navigated to and isn't sent for AUTO_SUBFRAME navigations.

Powered by Google App Engine
This is Rietveld 408576698