content/test/data/hang_before_unload.html - Issue 1825523002: Do not reset navigation state when BeforeUnload is cancelled by a commit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/hang_before_unload.html

Issue 1825523002: Do not reset navigation state when BeforeUnload is cancelled by a commit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/test/content_browser_test_utils_internal.cc ('K') | « content/test/content_browser_test_utils_internal.cc ('k') | testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2

	3 <head><title>Possible BeforeUnload</title>
	Charlie Reis 2016/03/29 18:33:21 Why "Possible"? Why "Possible"? clamy 2016/03/30 13:31:11 Because the first version did not have the dialog Show quoted text On 2016/03/29 18:33:21, Charlie Reis wrote: > Why "Possible"? Because the first version did not have the dialog all the time. Changed it to BeforeUnload dialog
	4 <script>

	5 function clickLink() {

	6 var evt = document.createEvent("MouseEvents");

	7 evt.initMouseEvent("click", true, true, window,

	8 0, 0, 0, 0, 0, false, false,

	9 false, false, 0, null);

	10 var target = document.getElementById("link");

	11 target.dispatchEvent(evt);

	12 }

	13

	14 function clickLinkSoon() {
	Charlie Reis 2016/03/29 18:33:21 nit: Use consistent indent. nit: Use consistent indent. clamy 2016/03/30 13:31:11 Done. Show quoted text On 2016/03/29 18:33:21, Charlie Reis wrote: > nit: Use consistent indent. Done.
	15 window.setTimeout(clickLink, 100);

	16 return true;

	17 }

	18

	19 window.addEventListener("beforeunload", function(e){
	Charlie Reis 2016/03/29 18:33:21 nit: Space before { nit: Space before { clamy 2016/03/30 13:31:11 Done. Show quoted text On 2016/03/29 18:33:21, Charlie Reis wrote: > nit: Space before { Done.
	20 var confirmationMessage = "foo";

	21 e.returnValue = confirmationMessage;

	22 return confirmationMessage;

	23 });
	Charlie Reis 2016/03/29 18:33:21 nit: 2 fewer spaces. nit: 2 fewer spaces. clamy 2016/03/30 13:31:11 Done. Show quoted text On 2016/03/29 18:33:21, Charlie Reis wrote: > nit: 2 fewer spaces. Done.
	24

	25 </script>

	26 </head>

	27

	28 <a href="title2.html" id="link">link</a><br>

	29

	30 </html>

OLD	NEW