Do not reset navigation state when BeforeUnload is cancelled by a commit

content/browser/web_contents/web_contents_impl_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "build/build_config.h"
 #include "content/browser/frame_host/navigation_entry_impl.h"
 #include "content/browser/renderer_host/render_widget_host_impl.h"
@@ skipping 797 matching lines @@
 
     Shell* new_shell = new_shell_observer.GetShell();
     WaitForLoadStop(new_shell->web_contents());
 
     EXPECT_EQ("foo",
               static_cast<WebContentsImpl*>(new_shell->web_contents())
                   ->GetFrameTree()->root()->frame_name());
   }
 }
 
+// TODO(clamy): Make the test work on Windows and on Mac.
+#if defined(OS_WIN) || defined(OS_MACOSX)

[clamy, 2016/03/29 13:01:50]

Apparently the test has some issues on Windows and MacOS. Since this a fix for a
crash I'd like to land it ASAP, and fix the test for other platforms in a second
patch.

[Charlie Reis, 2016/03/29 18:33:21]

Hmm, this concerns me, because the crash affects those platforms and it's not
clear to me why this would be platform specific.  Is the test going to be flaky
on Linux?

If you're confident it's due to a test-only issue on Windows and Mac, then
please elaborate in the comment a bit and I'll be ok with fixing it in a
followup.

[clamy, 2016/03/30 13:31:11]

From what I see on the logs, there is an issue with the navigation not being
caught. I think it may be due to the way the ShellJavascriptDialogManager is
implemented on Windows and Mac, which is different than on Linux. In particular,
I'm not sure it says proceed by default on those platforms, unlike on Linux.

+#define MAYBE_NoResetOnBeforeUnloadCanceledOnCommit \
+  DISABLED_NoResetOnBeforeUnloadCanceledOnCommit
+#else
+#define MAYBE_NoResetOnBeforeUnloadCanceledOnCommit \
+  NoResetOnBeforeUnloadCanceledOnCommit
+#endif
+// This CL tests that if a BeforeUnload dialog is destroyed due to the commit

[nasko, 2016/03/29 20:19:06]

nit: drop "CL". This is a test case, it just happens to be part of a CL, which
once committed won't exist as a concept.

[clamy, 2016/03/30 13:31:11]

Done. I did meant to write tests don't know what happened there.

+// of a cross-site navigation, it will not reset the loading state.
+IN_PROC_BROWSER_TEST_F(WebContentsImplBrowserTest,
+                       MAYBE_NoResetOnBeforeUnloadCanceledOnCommit) {
+  ASSERT_TRUE(embedded_test_server()->Start());
+  const GURL kStartURL(
+      embedded_test_server()->GetURL("/hang_before_unload.html"));
+  const GURL kCrossSiteURL(
+      embedded_test_server()->GetURL("bar.com", "/title1.html"));
+
+  // Navigate to a first web page with a BeforeUnload event listener.
+  EXPECT_TRUE(NavigateToURL(shell(), kStartURL));
+
+  // Start a cross-site navigation that will not commit for the moment.
+  NavigationDelayer cross_site_delayer(shell()->web_contents(), kCrossSiteURL);
+  shell()->LoadURL(kCrossSiteURL);
+  cross_site_delayer.WaitForNavigationPaused();
+
+  // Click on a link in the page. This will show the BeforeUnload dialog. Have

[nasko, 2016/03/29 20:19:06]

nit: "Have it hang" doesn't convey why or what hangs? Something along the lines
of "Ensure that dialog is not dismissed, which will cause ... to wait ...".

[clamy, 2016/03/30 13:31:11]

Done.

+  // it hang.
+  // Note: the javascript function executed will not do the link click but
+  // schedule it for afterwards. Since the BeforeUnload event is synchronous,
+  // clicking on the link right away would cause the ExecuteScript to never
+  // return.
+  SetProceedByDefaultOnBeforeUnload(shell(), false);
+  EXPECT_TRUE(ExecuteScript(shell()->web_contents(), "clickLinkSoon()"));
+  WaitForAppModalDialog(shell());
+
+  // Have the cross-site navigation commit. The main RenderFrameHost should
+  // still be loading after that.
+  cross_site_delayer.ResumeNavigation();
+  cross_site_delayer.WaitForNavigationFinished();
+  EXPECT_TRUE(shell()->web_contents()->IsLoading());
+}
+
 }  // namespace content