Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1825513003: [interpreter] Don't go to the runtime for ForInDone. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Don't go to the runtime for ForInDone. The bytecode handler for ForInDone can just do a word comparison on index and cache length instead of calling out to %ForInDone. R=rmcilroy@chromium.org Committed: https://crrev.com/d9e1171839253d17279d6f7353b30d5b337a8849 Cr-Commit-Position: refs/heads/master@{#35023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/interpreter/interpreter.cc View 1 chunk +17 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-23 07:52:41 UTC) #1
Benedikt Meurer
Hey Ross, Here's another easy one. Please take a look. Thanks, Benedikt
4 years, 9 months ago (2016-03-23 07:53:16 UTC) #2
rmcilroy
Lgtm
4 years, 9 months ago (2016-03-23 09:44:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825513003/1
4 years, 9 months ago (2016-03-23 09:55:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 09:57:01 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 09:57:58 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9e1171839253d17279d6f7353b30d5b337a8849
Cr-Commit-Position: refs/heads/master@{#35023}

Powered by Google App Engine
This is Rietveld 408576698