Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1825513002: PPC: [crankshaft] Fixing ES6 tail call elimination. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [crankshaft] Fixing ES6 tail call elimination. Port acbb968dedd2b02b5447215a579cf4cdc99bc69a Port 66e22b79e812437aa3be168da4612e64a2de6728 Original commit messages: In case when F inlined normal call to G which tail calls H we should not write translation for G for the tail call site. Otherwise we will see G in a stack trace inside H. This CL also enables all existing tests related to ES6 tail call elimination and adds more combinations. Always generate lazy bailout points for tail calls because Debugger could still require them to inspect optimized frames. R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:596473, v8:4698 LOG=N Committed: https://crrev.com/a6bf5bbdeacb428e5dd4dc10d9446feea7dd4ac2 Cr-Commit-Position: refs/heads/master@{#34996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -10 lines) Patch
M src/crankshaft/ppc/lithium-ppc.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 4 chunks +35 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-22 15:26:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825513002/1
4 years, 9 months ago (2016-03-22 15:26:34 UTC) #3
Igor Sheludko
lgtm
4 years, 9 months ago (2016-03-22 15:29:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 15:47:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825513002/1
4 years, 9 months ago (2016-03-22 16:35:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 16:37:07 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 16:38:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6bf5bbdeacb428e5dd4dc10d9446feea7dd4ac2
Cr-Commit-Position: refs/heads/master@{#34996}

Powered by Google App Engine
This is Rietveld 408576698