Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1825473002: nanobench: Stop reporting median_ms, it's no better than min_ms. (Closed)

Created:
4 years, 9 months ago by jcgregorio
Modified:
4 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M bench/nanobench.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
jcgregorio
4 years, 9 months ago (2016-03-22 11:40:04 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825473002/1
4 years, 9 months ago (2016-03-22 11:40:14 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 11:49:44 UTC) #7
mtklein
lgtm We running out of stat/s ?
4 years, 9 months ago (2016-03-22 12:21:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825473002/1
4 years, 9 months ago (2016-03-22 12:26:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6ae6dc7b0a47d92f87f65a7cb52855c06c480274
4 years, 9 months ago (2016-03-22 12:27:05 UTC) #12
jcgregorio
4 years, 9 months ago (2016-03-22 12:27:30 UTC) #13
Message was sent while issue was closed.
On 2016/03/22 at 12:21:55, mtklein wrote:
> lgtm
> 
> We running out of stat/s ?

Startup time can be a little slow with 560K traces. Trying to trim out data we
aren't using.

Powered by Google App Engine
This is Rietveld 408576698