Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1825463003: Fix uninitialized value in SiteEngagementHelper. (Closed)

Created:
4 years, 9 months ago by calamity
Modified:
4 years, 9 months ago
Reviewers:
dominickn
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized value in SiteEngagementHelper. BUG=597196 Committed: https://crrev.com/da476e8cc070cb3ba08398daa88efe22aa2fcf2c Cr-Commit-Position: refs/heads/master@{#382808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/engagement/site_engagement_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
calamity
Feel free to put this on the CQ if it looks fine to you.
4 years, 9 months ago (2016-03-23 07:36:11 UTC) #2
dominickn
lgtm
4 years, 9 months ago (2016-03-23 08:10:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825463003/1
4 years, 9 months ago (2016-03-23 08:10:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 08:15:41 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 08:17:03 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/da476e8cc070cb3ba08398daa88efe22aa2fcf2c
Cr-Commit-Position: refs/heads/master@{#382808}

Powered by Google App Engine
This is Rietveld 408576698