Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1825443002: IntersectionObserver: omit thresholds attribute. (Closed)

Created:
4 years, 9 months ago by szager1
Modified:
4 years, 9 months ago
Reviewers:
philipj_slow, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: omit thresholds attribute. The IDL type for the thresholds attribute should be FrozenArray, but FrozenArray isn't implemented yet, so leave it out for now. R=ojan@chromium.org,philipj@opera.com BUG=540528 Committed: https://crrev.com/8e1693a1f8dbedc1eed2777464f8a35ffa0da8e4 Cr-Commit-Position: refs/heads/master@{#382539}

Patch Set 1 #

Patch Set 2 : TODO fix #

Patch Set 3 : Fix global-interface-listing expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/intersection-observer/observer-attributes.html View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/intersection-observer/observer-attributes-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.idl View 1 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
szager1
4 years, 9 months ago (2016-03-22 04:04:38 UTC) #1
ojan
lgtm
4 years, 9 months ago (2016-03-22 04:12:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825443002/20001
4 years, 9 months ago (2016-03-22 04:12:31 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/192543)
4 years, 9 months ago (2016-03-22 05:21:31 UTC) #6
philipj_slow
lgtm webexposed/global-interface-listing.html is sad as usual :)
4 years, 9 months ago (2016-03-22 06:04:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825443002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825443002/40001
4 years, 9 months ago (2016-03-22 08:22:47 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-22 09:41:40 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 09:42:50 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8e1693a1f8dbedc1eed2777464f8a35ffa0da8e4
Cr-Commit-Position: refs/heads/master@{#382539}

Powered by Google App Engine
This is Rietveld 408576698