Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1825423003: Use scoped_ptr for MockUDPClientSocket in quic_http_stream_test.cc and bidirectional_stream_quic_im… (Closed)

Created:
4 years, 9 months ago by xunjieli
Modified:
4 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Hamilton
Base URL:
https://chromium.googlesource.com/chromium/src.git@log
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr for MockUDPClientSocket in quic_http_stream_test.cc and bidirectional_stream_quic_impl_unittest.cc BUG=584338 Committed: https://crrev.com/b53b38cca6a4e89d3e9b1a2762ee6d7ebb2b77d2 Cr-Commit-Position: refs/heads/master@{#383068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M net/quic/bidirectional_stream_quic_impl_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
xunjieli
4 years, 9 months ago (2016-03-23 22:26:31 UTC) #2
mmenke
LGTM, thanks!
4 years, 9 months ago (2016-03-24 15:17:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825423003/1
4 years, 9 months ago (2016-03-24 15:19:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 15:54:49 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 15:56:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b53b38cca6a4e89d3e9b1a2762ee6d7ebb2b77d2
Cr-Commit-Position: refs/heads/master@{#383068}

Powered by Google App Engine
This is Rietveld 408576698