Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1825423002: Add <algorithm> header to remote_device_loader.cc (Closed)

Created:
4 years, 9 months ago by xyzzyz
Modified:
4 years, 9 months ago
Reviewers:
xiyuan, Tim Song
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add <algorithm> header to remote_device_loader.cc The code is using std::find_if, but doesn't include the <algorithm> header. It works, because it is pulled as a dependency by something else. I am currently doing an update to third_party library that's currently pulling that header, but will no longer do after the update, breaking this code. BUG=597321 Committed: https://crrev.com/fc8af01635be94103d4ef5da8846ad95bc907291 Cr-Commit-Position: refs/heads/master@{#382903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/proximity_auth/remote_device_loader.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xyzzyz
tengs@chromium.org: Please review changes in xiyuan@chromium.org: Please review changes in
4 years, 9 months ago (2016-03-23 18:35:42 UTC) #2
xiyuan
lgtm
4 years, 9 months ago (2016-03-23 19:20:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825423002/1
4 years, 9 months ago (2016-03-23 19:38:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 19:44:33 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 19:46:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc8af01635be94103d4ef5da8846ad95bc907291
Cr-Commit-Position: refs/heads/master@{#382903}

Powered by Google App Engine
This is Rietveld 408576698