Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: components/leveldb/leveldb_service_unittest.cc

Issue 1825413003: leveldb_service: Attempt to fix deadlock on shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/leveldb/leveldb_file_thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/leveldb/leveldb_service_unittest.cc
diff --git a/components/leveldb/leveldb_service_unittest.cc b/components/leveldb/leveldb_service_unittest.cc
index 7711deb099281fdb4c9dbf23886615395167be9c..c6241a8bd846d6d8c11152e9295fe8f91348f8b3 100644
--- a/components/leveldb/leveldb_service_unittest.cc
+++ b/components/leveldb/leveldb_service_unittest.cc
@@ -32,6 +32,12 @@ class LevelDBApptest : public mojo::test::ShellTest {
connector()->ConnectToInterface("mojo:leveldb", &leveldb_);
}
+ void TearDown() override {
+ leveldb_.reset();
+ files_.reset();
+ ShellTest::TearDown();
+ }
+
// Note: This has an out parameter rather than returning the |DirectoryPtr|,
// since |ASSERT_...()| doesn't work with return values.
void GetUserDataDir(filesystem::DirectoryPtr* directory) {
@@ -52,13 +58,7 @@ class LevelDBApptest : public mojo::test::ShellTest {
DISALLOW_COPY_AND_ASSIGN(LevelDBApptest);
};
-#if defined(OS_LINUX)
-// Flaky on Linux: http://crbug.com/594977,
-#define MAYBE_Basic DISABLED_Basic
-#else
-#define MAYBE_Basic Basic
-#endif
-TEST_F(LevelDBApptest, MAYBE_Basic) {
+TEST_F(LevelDBApptest, Basic) {
filesystem::DirectoryPtr directory;
GetUserDataDir(&directory);
@@ -274,12 +274,6 @@ TEST_F(LevelDBApptest, GetFromSnapshots) {
EXPECT_EQ("value", value.To<std::string>());
}
-#if defined(OS_LINUX)
-// Flaky on Linux: http://crbug.com/594977,
-#define MAYBE_InvalidArgumentOnInvalidSnapshot DISABLED_InvalidArgumentOnInvalidSnapshot
-#else
-#define MAYBE_InvalidArgumentOnInvalidSnapshot InvalidArgumentOnInvalidSnapshot
-#endif
TEST_F(LevelDBApptest, InvalidArgumentOnInvalidSnapshot) {
filesystem::DirectoryPtr directory;
GetUserDataDir(&directory);
« no previous file with comments | « components/leveldb/leveldb_file_thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698