Source/core/rendering/RenderBox.cpp - Issue 18254006: Repaint issues with vertical text which has absolute (or fixed) position specified for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 18254006: Repaint issues with vertical text which has absolute (or fixed) position specified for it. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modifying testcase as per review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/linux/editing/selection/repaint-rect-for-vertical-writing-mode-with-positioned-root-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index 2be12319e16d8c5aecdf19d34f61fc19877a4bad..d79d647ed5ecee332ee187170f15f82bf56c4466 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -2022,7 +2022,7 @@ void RenderBox::mapRectToPaintInvalidationBacking(const RenderLayerModelObject*

if (!o)

return;

- if (isWritingModeRoot() && !isOutOfFlowPositioned())

+ if (isWritingModeRoot() && style()->isFlippedBlocksWritingMode())

ojan 2014/07/09 17:23:08 flipForWritingMode already has an early return for

arpitab_ 2014/07/10 13:17:15 Done.

flipForWritingMode(rect);

LayoutPoint topLeft = rect.location();