Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: Source/core/rendering/RenderBox.cpp

Issue 18254006: Repaint issues with vertical text which has absolute (or fixed) position specified for it. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removing the extra check Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 2004 matching lines...) Expand 10 before | Expand all | Expand 10 after
2015 if (paintInvalidationContainer->style()->isFlippedBlocksWritingMode()) 2015 if (paintInvalidationContainer->style()->isFlippedBlocksWritingMode())
2016 flipForWritingMode(rect); 2016 flipForWritingMode(rect);
2017 return; 2017 return;
2018 } 2018 }
2019 2019
2020 bool containerSkipped; 2020 bool containerSkipped;
2021 RenderObject* o = container(paintInvalidationContainer, &containerSkipped); 2021 RenderObject* o = container(paintInvalidationContainer, &containerSkipped);
2022 if (!o) 2022 if (!o)
2023 return; 2023 return;
2024 2024
2025 if (isWritingModeRoot() && !isOutOfFlowPositioned()) 2025 if (isWritingModeRoot())
2026 flipForWritingMode(rect); 2026 flipForWritingMode(rect);
2027 2027
2028 LayoutPoint topLeft = rect.location(); 2028 LayoutPoint topLeft = rect.location();
2029 topLeft.move(locationOffset()); 2029 topLeft.move(locationOffset());
2030 2030
2031 EPosition position = styleToUse->position(); 2031 EPosition position = styleToUse->position();
2032 2032
2033 // We are now in our parent container's coordinate space. Apply our transfo rm to obtain a bounding box 2033 // We are now in our parent container's coordinate space. Apply our transfo rm to obtain a bounding box
2034 // in the parent's coordinate space that encloses us. 2034 // in the parent's coordinate space that encloses us.
2035 if (hasLayer() && layer()->transform()) { 2035 if (hasLayer() && layer()->transform()) {
(...skipping 2630 matching lines...) Expand 10 before | Expand all | Expand 10 after
4666 return 0; 4666 return 0;
4667 4667
4668 if (!layoutState && !flowThreadContainingBlock()) 4668 if (!layoutState && !flowThreadContainingBlock())
4669 return 0; 4669 return 0;
4670 4670
4671 RenderBlock* containerBlock = containingBlock(); 4671 RenderBlock* containerBlock = containingBlock();
4672 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop(); 4672 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop();
4673 } 4673 }
4674 4674
4675 } // namespace WebCore 4675 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/platform/linux/editing/selection/repaint-rect-for-vertical-writing-mode-with-positioned-root-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698