LayoutTests/editing/inserting/insert-paragraph-between-text-with-positioned-root.html - Issue 18254006: Repaint issues with vertical text which has absolute (or fixed) position specified for it.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/inserting/insert-paragraph-between-text-with-positioned-root.html

Issue 18254006: Repaint issues with vertical text which has absolute (or fixed) position specified for it. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing nit in testcase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/platform/linux/editing/inserting/insert-paragraph-between-text-with-positioned-root-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	ojan 2014/07/08 23:53:30 Please remove the html and head element as this te Please remove the html and head element as this test doesn't depend on them. arpitab_ 2014/07/09 13:57:26 Done. Show quoted text On 2014/07/08 23:53:30, ojan-only-code-yellow-reviews wrote: > Please remove the html and head element as this test doesn't depend on them. Done.
	4 <script src="../../fast/repaint/resources/text-based-repaint.js" type="text/java script"></script>
	ojan 2014/07/08 23:53:30 No need for the type attribute. No need for the type attribute. arpitab_ 2014/07/09 13:57:26 Done. Show quoted text On 2014/07/08 23:53:30, ojan-only-code-yellow-reviews wrote: > No need for the type attribute. Done.
	5 <style>

	6 .textArea {

	7 position: absolute; left: 0px; top: 200px;
	ojan 2014/07/08 23:53:30 Please put each of these on their own line. Please put each of these on their own line. arpitab_ 2014/07/09 13:57:26 Done. Show quoted text On 2014/07/08 23:53:30, ojan-only-code-yellow-reviews wrote: > Please put each of these on their own line. Done.
	8 -webkit-writing-mode: vertical-rl;

	9 width: 200px;

	10 height: 300px;

	11 border: 1px solid black;

	12 outline-style: none;

	13 }

	14 </style>

	15 <script>

	16 if (window.testRunner)

	17 testRunner.dumpAsTextWithPixelResults();

	18

	19 function repaintTest() {

	20 var testElement = document.getElementById("test");

	21 testElement.focus();

	22

	23 var selection = window.getSelection();

	24 selection.collapse(testElement, 1);

	25 selection.modify("move", "backward", "character");

	26 document.execCommand("InsertParagraph");
	ojan 2014/07/08 23:53:30 execCommands and selections are complicated and ma execCommands and selections are complicated and make for a hard to maintain test. Can you make a test case that doesn't depend on selections or execCommand? It should be possible to create one that does the same thing with regular DOM operations.
	27 }

	28 </script>

	29 </head>

	30 <body onload="runRepaintTest()">

	31 <div class="textArea" contenteditable="true">

	32 <p>

	33 <span id="test">Some text in vertical mode</span>

	34 </p>

	35 </div>

	36 </body>

	37 </html>

OLD	NEW