Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Unified Diff: src/gpu/vk/GrVkTransferBuffer.h

Issue 1825393002: Consolidate GPU buffer implementations (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: gyp Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/vk/GrVkTransferBuffer.h
diff --git a/src/gpu/vk/GrVkTransferBuffer.h b/src/gpu/vk/GrVkTransferBuffer.h
index f978df95fd744cf7cc14138c35e1e544e96c5e24..3cf3d19087f1804551abd45494fdb23a5e592b20 100644
--- a/src/gpu/vk/GrVkTransferBuffer.h
+++ b/src/gpu/vk/GrVkTransferBuffer.h
@@ -8,20 +8,15 @@
#ifndef GrVkTransferBuffer_DEFINED
#define GrVkTransferBuffer_DEFINED
-#include "GrTransferBuffer.h"
#include "GrVkBuffer.h"
#include "vk/GrVkInterface.h"
class GrVkGpu;
-class GrVkTransferBuffer : public GrTransferBuffer, public GrVkBuffer {
+class GrVkTransferBuffer : public GrVkBuffer {
public:
- static GrVkTransferBuffer* Create(GrVkGpu* gpu, size_t size, GrVkBuffer::Type type);
-
-protected:
- void onAbandon() override;
- void onRelease() override;
+ static GrVkTransferBuffer* Create(GrVkGpu* gpu, size_t size, GrBufferType type);
private:
GrVkTransferBuffer(GrVkGpu* gpu, const GrVkBuffer::Desc& desc,
@@ -29,26 +24,7 @@ private:
void setMemoryBacking(SkTraceMemoryDump* traceMemoryDump,
const SkString& dumpName) const override;
- void* onMap() override {
- if (!this->wasDestroyed()) {
- return this->vkMap(this->getVkGpu());
- } else {
- return nullptr;
- }
- }
-
- void onUnmap() override {
- if (!this->wasDestroyed()) {
- this->vkUnmap(this->getVkGpu());
- }
- }
-
- GrVkGpu* getVkGpu() const {
- SkASSERT(!this->wasDestroyed());
- return reinterpret_cast<GrVkGpu*>(this->getGpu());
- }
-
- typedef GrTransferBuffer INHERITED;
+ typedef GrVkBuffer INHERITED;
};
#endif

Powered by Google App Engine
This is Rietveld 408576698