Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: src/gpu/vk/GrVkTransferBuffer.cpp

Issue 1825393002: Consolidate GPU buffer implementations (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: gyp Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/vk/GrVkTransferBuffer.cpp
diff --git a/src/gpu/vk/GrVkTransferBuffer.cpp b/src/gpu/vk/GrVkTransferBuffer.cpp
index 37306277642468905be01953fefa5be45f9d6690..799e319654e908918045d4b1e0307603f87af7d1 100644
--- a/src/gpu/vk/GrVkTransferBuffer.cpp
+++ b/src/gpu/vk/GrVkTransferBuffer.cpp
@@ -10,10 +10,10 @@
#include "SkTraceMemoryDump.h"
-GrVkTransferBuffer* GrVkTransferBuffer::Create(GrVkGpu* gpu, size_t size, GrVkBuffer::Type type) {
+GrVkTransferBuffer* GrVkTransferBuffer::Create(GrVkGpu* gpu, size_t size, GrBufferType type) {
GrVkBuffer::Desc desc;
- desc.fDynamic = false;
- SkASSERT(GrVkBuffer::kCopyRead_Type == type || GrVkBuffer::kCopyWrite_Type == type);
+ desc.fAccessPattern = kStream_GrAccessPattern;
+ SkASSERT(kXferCpuToGpu_GrBufferType == type || kXferGpuToCpu_GrBufferType == type);
desc.fType = type;
desc.fSizeInBytes = size;
@@ -31,24 +31,10 @@ GrVkTransferBuffer* GrVkTransferBuffer::Create(GrVkGpu* gpu, size_t size, GrVkBu
GrVkTransferBuffer::GrVkTransferBuffer(GrVkGpu* gpu, const GrVkBuffer::Desc& desc,
const GrVkBuffer::Resource* bufferResource)
- : INHERITED(gpu, desc.fSizeInBytes)
- , GrVkBuffer(desc, bufferResource) {
+ : INHERITED(gpu, desc, bufferResource) {
this->registerWithCache();
}
-void GrVkTransferBuffer::onRelease() {
- if (!this->wasDestroyed()) {
- this->vkRelease(this->getVkGpu());
- }
-
- INHERITED::onRelease();
-}
-
-void GrVkTransferBuffer::onAbandon() {
- this->vkAbandon();
- INHERITED::onAbandon();
-}
-
void GrVkTransferBuffer::setMemoryBacking(SkTraceMemoryDump* traceMemoryDump,
const SkString& dumpName) const {
SkString buffer_id;

Powered by Google App Engine
This is Rietveld 408576698