Subzero. Fixes valgrind errors.

Subzero. Fixes valgrind errors.

Valgrind used to report errors about uninitialized variable access in
Subzero, when it was built with -O2. The problem was traced to

size_t Alignment = Var->getAlignment;
Alignment = std::max(MinAlignment, Var->getAlignment())

Apparently, the compiler will not correctly zero-extend
Var->getAlignment(), and thus Alignment's upper 32-bits would be
garbage.

BUG=
R=kschimpf@google.com, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=267f2bf9c3f384bb007c686d165b32959143a247

[John, 2016-03-23 15:51:09]

jpp@chromium.org changed reviewers:
+ eholk@chromium.org, kschimpf@google.com, sehr@chromium.org,
stichnot@chromium.org

[Karl, 2016-03-23 20:56:24]

lgtm

[Jim Stichnoth, 2016-03-23 21:08:23]

lgtm

https://codereview.chromium.org/1825363003/diff/20001/src/IceELFObjectWriter.cpp
File src/IceELFObjectWriter.cpp (right):

https://codereview.chromium.org/1825363003/diff/20001/src/IceELFObjectWriter....
src/IceELFObjectWriter.cpp:392: const Elf64_Xword Align =
Use auto here?  given std::max<Elf64_Xword>

[John, 2016-03-24 13:02:26]

https://codereview.chromium.org/1825363003/diff/20001/src/IceELFObjectWriter.cpp
File src/IceELFObjectWriter.cpp (right):

https://codereview.chromium.org/1825363003/diff/20001/src/IceELFObjectWriter....
src/IceELFObjectWriter.cpp:392: const Elf64_Xword Align =
On 2016/03/23 21:08:22, stichnot wrote:
> Use auto here?  given std::max<Elf64_Xword>

auto everywhere!!!! :)

[John, 2016-03-24 13:11:32]

Description was changed from

==========
Subzero. Fixes valgrind errors.

Valgrind used to report errors about uninitialized variable access in
Subzero, when it was built with -O2. The problem was traced to

size_t Alignment = Var->getAlignment;
Alignment = std::max(MinAlignment, Var->getAlignment())

Apparently, the compiler will not correctly zero-extend
Var->getAlignment(), and thus Alignment's upper 32-bits would be
garbage.

BUG=
==========

to

==========
Subzero. Fixes valgrind errors.

Valgrind used to report errors about uninitialized variable access in
Subzero, when it was built with -O2. The problem was traced to

size_t Alignment = Var->getAlignment;
Alignment = std::max(MinAlignment, Var->getAlignment())

Apparently, the compiler will not correctly zero-extend
Var->getAlignment(), and thus Alignment's upper 32-bits would be
garbage.

BUG=
R=kschimpf@google.com, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[John, 2016-03-24 13:11:34]

Committed patchset #3 (id:40001) manually as
267f2bf9c3f384bb007c686d165b32959143a247 (presubmit successful).