Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1825363002: Revert of [elements] Minor hardening and cleanup of concat (Closed)

Created:
4 years, 9 months ago by Michael Achenbach
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [elements] Minor hardening and cleanup of concat (patchset #7 id:120001 of https://codereview.chromium.org/1812753004/ ) Reason for revert: [Sheriff] Something seems to leak: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/10838 I don't see the direct connection to this CL though... Original issue's description: > [elements] Minor hardening and cleanup of concat > > BUG= > > Committed: https://crrev.com/b98b3fbbe3dd14548cb356339f52403c07ef33f4 > Cr-Commit-Position: refs/heads/master@{#35027} TBR=jkummerow@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d30d861a0cb0da11efd3b30eb3d03fbe56b4ba23 Cr-Commit-Position: refs/heads/master@{#35028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M src/elements.cc View 2 chunks +26 lines, -30 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of [elements] Minor hardening and cleanup of concat
4 years, 9 months ago (2016-03-23 13:23:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825363002/1
4 years, 9 months ago (2016-03-23 13:23:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 13:23:43 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d30d861a0cb0da11efd3b30eb3d03fbe56b4ba23 Cr-Commit-Position: refs/heads/master@{#35028}
4 years, 9 months ago (2016-03-23 13:25:25 UTC) #6
Michael Achenbach
4 years, 9 months ago (2016-03-23 16:09:04 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1827573003/ by machenbach@chromium.org.

The reason for reverting is: Test disabled. See:
https://codereview.chromium.org/1830583002/.

Powered by Google App Engine
This is Rietveld 408576698