Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1825333003: Planar ramp() for S32 linear gradients (Closed)

Created:
4 years, 9 months ago by f(malita)
Modified:
4 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
M src/effects/gradients/Sk4fGradientPriv.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/effects/gradients/Sk4fLinearGradient.cpp View 1 2 chunks +36 lines, -0 lines 2 comments Download

Messages

Total messages: 13 (5 generated)
f(malita)
Speeds up GM:gradient_many_stops_4f by ~10% in S32 mode.
4 years, 9 months ago (2016-03-23 18:19:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825333003/20001
4 years, 9 months ago (2016-03-23 18:19:26 UTC) #4
mtklein
lgtm
4 years, 9 months ago (2016-03-23 18:27:27 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-23 18:34:39 UTC) #7
mtklein
https://codereview.chromium.org/1825333003/diff/20001/src/effects/gradients/Sk4fLinearGradient.cpp File src/effects/gradients/Sk4fLinearGradient.cpp (right): https://codereview.chromium.org/1825333003/diff/20001/src/effects/gradients/Sk4fLinearGradient.cpp#newcode77 src/effects/gradients/Sk4fLinearGradient.cpp:77: ::store(Sk4f(c4x.r[n & 2], c4x.g[n & 2], c4x.b[n & 2], ...
4 years, 9 months ago (2016-03-23 19:05:27 UTC) #8
mtklein
https://codereview.chromium.org/1825333003/diff/20001/src/effects/gradients/Sk4fLinearGradient.cpp File src/effects/gradients/Sk4fLinearGradient.cpp (right): https://codereview.chromium.org/1825333003/diff/20001/src/effects/gradients/Sk4fLinearGradient.cpp#newcode77 src/effects/gradients/Sk4fLinearGradient.cpp:77: ::store(Sk4f(c4x.r[n & 2], c4x.g[n & 2], c4x.b[n & 2], ...
4 years, 9 months ago (2016-03-23 19:12:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825333003/20001
4 years, 9 months ago (2016-03-23 19:27:19 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 19:28:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/83aa9208dab96f1b6affa8167522e9a94afd70a5

Powered by Google App Engine
This is Rietveld 408576698