Source/core/editing/CompositeEditCommand.h - Issue 182533004: Fix crash in CompositeEditCommand::cloneParagraphUnderNewElement().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.h

Issue 182533004: Fix crash in CompositeEditCommand::cloneParagraphUnderNewElement(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/execCommand/resources/format-block-crash-iframe.html ('k') | Source/core/editing/CompositeEditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/CompositeEditCommand.h

diff --git a/Source/core/editing/CompositeEditCommand.h b/Source/core/editing/CompositeEditCommand.h

index 2b8a948ce0cc0cf064ff32d8a3f20db310770471..0bcdd3f1c0f221659bf745d7a055a26095669fa8 100644

--- a/Source/core/editing/CompositeEditCommand.h

+++ b/Source/core/editing/CompositeEditCommand.h

@@ -152,7 +152,7 @@ protected:

void moveParagraph(const VisiblePosition&, const VisiblePosition&, const VisiblePosition&, bool preserveSelection = false, bool preserveStyle = true, Node* constrainingAncestor = 0);

void moveParagraphs(const VisiblePosition&, const VisiblePosition&, const VisiblePosition&, bool preserveSelection = false, bool preserveStyle = true, Node* constrainingAncestor = 0);

void moveParagraphWithClones(const VisiblePosition& startOfParagraphToMove, const VisiblePosition& endOfParagraphToMove, Element* blockElement, Node* outerNode);

- void cloneParagraphUnderNewElement(Position& start, Position& end, Node* outerNode, Element* blockElement);

+ void cloneParagraphUnderNewElement(const Position& start, const Position& end, Node* outerNode, Element* blockElement);

void cleanupAfterDeletion(VisiblePosition destination = VisiblePosition());

bool breakOutOfEmptyListItem();