Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1825323002: bindings: Removes a wrong ASSERT: Exception must be thrown across origins. (Closed)

Created:
4 years, 9 months ago by Yuki
Modified:
4 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bindings: Removes a wrong ASSERT: Exception must be thrown across origins. It's a wrong assumption that an exception should be thrown across origins if the exception is thrown when we're creating a DOM wrapper for Location. It's wrong because 1) Even if it's cross origins, we should be able to create a DOM wrapper for Location in general because Location is cross-origin-accessible. 2) Even if it's same origins, it's possible that an exception will be thrown due to the runtime error, such as OOM. Thus, removes the wrong ASSERT at DOMWindow::sanitizedCrossDomainAccessErrorMessage BUG=594919 Committed: https://crrev.com/3174947e46175db49b0fae95863c79cac5f6ba4e Cr-Commit-Position: refs/heads/master@{#382841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuki
Could you review this CL?
4 years, 9 months ago (2016-03-23 11:01:01 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-03-23 11:03:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825323002/1
4 years, 9 months ago (2016-03-23 12:20:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 13:20:45 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 13:21:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3174947e46175db49b0fae95863c79cac5f6ba4e
Cr-Commit-Position: refs/heads/master@{#382841}

Powered by Google App Engine
This is Rietveld 408576698