Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2500)

Unified Diff: content/public/common/frame_navigate_params.h

Issue 1825273002: Add more out of line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/frame_replication_state.cc ('k') | gpu/command_buffer/service/gpu_preferences.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/frame_navigate_params.h
diff --git a/content/public/common/frame_navigate_params.h b/content/public/common/frame_navigate_params.h
index 3b8dd90d25d38276b3261c00f3878e5cf1a705cb..49c039f357d9dc69d30682c68c777303659d6525 100644
--- a/content/public/common/frame_navigate_params.h
+++ b/content/public/common/frame_navigate_params.h
@@ -12,6 +12,7 @@
#include "content/common/content_export.h"
#include "content/public/common/referrer.h"
+#include "ipc/ipc_message_utils.h"
#include "net/base/host_port_pair.h"
#include "ui/base/page_transition_types.h"
#include "url/gurl.h"
@@ -19,7 +20,10 @@
namespace content {
// Struct used by WebContentsObserver.
-struct CONTENT_EXPORT FrameNavigateParams {
+// Note that we derived from IPC::NoParams here, because this struct is used in
+// an IPC struct as a parent. Deriving from NoParams allows us to by-pass the
+// out of line constructor checks in our clang plugins.
+struct CONTENT_EXPORT FrameNavigateParams : public IPC::NoParams {
FrameNavigateParams();
FrameNavigateParams(const FrameNavigateParams& other);
~FrameNavigateParams();
« no previous file with comments | « content/common/frame_replication_state.cc ('k') | gpu/command_buffer/service/gpu_preferences.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698