 Chromium Code Reviews
 Chromium Code Reviews Issue 1825273002:
  Add more out of line copy ctors for complex classes.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1825273002:
  Add more out of line copy ctors for complex classes.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW | 
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 #ifndef CONTENT_PUBLIC_COMMON_FRAME_NAVIGATE_PARAMS_H_ | 5 #ifndef CONTENT_PUBLIC_COMMON_FRAME_NAVIGATE_PARAMS_H_ | 
| 6 #define CONTENT_PUBLIC_COMMON_FRAME_NAVIGATE_PARAMS_H_ | 6 #define CONTENT_PUBLIC_COMMON_FRAME_NAVIGATE_PARAMS_H_ | 
| 7 | 7 | 
| 8 #include <stdint.h> | 8 #include <stdint.h> | 
| 9 | 9 | 
| 10 #include <string> | 10 #include <string> | 
| 11 #include <vector> | 11 #include <vector> | 
| 12 | 12 | 
| 13 #include "content/common/content_export.h" | 13 #include "content/common/content_export.h" | 
| 14 #include "content/public/common/referrer.h" | 14 #include "content/public/common/referrer.h" | 
| 15 #include "ipc/ipc_message_utils.h" | |
| 15 #include "net/base/host_port_pair.h" | 16 #include "net/base/host_port_pair.h" | 
| 16 #include "ui/base/page_transition_types.h" | 17 #include "ui/base/page_transition_types.h" | 
| 17 #include "url/gurl.h" | 18 #include "url/gurl.h" | 
| 18 | 19 | 
| 19 namespace content { | 20 namespace content { | 
| 20 | 21 | 
| 21 // Struct used by WebContentsObserver. | 22 // Struct used by WebContentsObserver. | 
| 22 struct CONTENT_EXPORT FrameNavigateParams { | 23 struct CONTENT_EXPORT FrameNavigateParams : public IPC::NoParams { | 
| 
vmpstr
2016/03/22 23:22:43
Note that this is required, because there is an IP
 
dcheng
2016/03/22 23:25:06
It's definitely kind of a hack, but I think it's O
 
no sievers
2016/03/22 23:37:20
I'd put a comment though.
 
vmpstr
2016/03/22 23:57:43
Done.
 | |
| 23 FrameNavigateParams(); | 24 FrameNavigateParams(); | 
| 24 FrameNavigateParams(const FrameNavigateParams& other); | 25 FrameNavigateParams(const FrameNavigateParams& other); | 
| 25 ~FrameNavigateParams(); | 26 ~FrameNavigateParams(); | 
| 26 | 27 | 
| 27 // Page ID of this navigation. The renderer creates a new unique page ID | 28 // Page ID of this navigation. The renderer creates a new unique page ID | 
| 28 // anytime a new session history entry is created. This means you'll get new | 29 // anytime a new session history entry is created. This means you'll get new | 
| 29 // page IDs for user actions, and the old page IDs will be reloaded when | 30 // page IDs for user actions, and the old page IDs will be reloaded when | 
| 30 // iframes are loaded automatically. | 31 // iframes are loaded automatically. | 
| 31 int32_t page_id; | 32 int32_t page_id; | 
| 32 | 33 | 
| (...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 84 // Contents MIME type of main frame. | 85 // Contents MIME type of main frame. | 
| 85 std::string contents_mime_type; | 86 std::string contents_mime_type; | 
| 86 | 87 | 
| 87 // Remote address of the socket which fetched this resource. | 88 // Remote address of the socket which fetched this resource. | 
| 88 net::HostPortPair socket_address; | 89 net::HostPortPair socket_address; | 
| 89 }; | 90 }; | 
| 90 | 91 | 
| 91 } // namespace content | 92 } // namespace content | 
| 92 | 93 | 
| 93 #endif // CONTENT_PUBLIC_COMMON_FRAME_NAVIGATE_PARAMS_H_ | 94 #endif // CONTENT_PUBLIC_COMMON_FRAME_NAVIGATE_PARAMS_H_ | 
| OLD | NEW |