Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: cc/surfaces/surface_manager.cc

Issue 1825273002: Add more out of line copy ctors for complex classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/surfaces/surface_manager.h" 5 #include "cc/surfaces/surface_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "cc/surfaces/surface.h" 11 #include "cc/surfaces/surface.h"
12 #include "cc/surfaces/surface_factory_client.h" 12 #include "cc/surfaces/surface_factory_client.h"
13 #include "cc/surfaces/surface_id_allocator.h" 13 #include "cc/surfaces/surface_id_allocator.h"
14 14
15 namespace cc { 15 namespace cc {
16 16
17 SurfaceManager::ClientSourceMapping::ClientSourceMapping() 17 SurfaceManager::ClientSourceMapping::ClientSourceMapping()
18 : client(nullptr), source(nullptr) {} 18 : client(nullptr), source(nullptr) {}
19 19
20 SurfaceManager::ClientSourceMapping::ClientSourceMapping(
21 const ClientSourceMapping& other) = default;
22
20 SurfaceManager::ClientSourceMapping::~ClientSourceMapping() { 23 SurfaceManager::ClientSourceMapping::~ClientSourceMapping() {
21 DCHECK(is_empty()) << "client: " << client 24 DCHECK(is_empty()) << "client: " << client
22 << ", children: " << children.size(); 25 << ", children: " << children.size();
23 } 26 }
24 27
25 SurfaceManager::SurfaceManager() { 28 SurfaceManager::SurfaceManager() {
26 thread_checker_.DetachFromThread(); 29 thread_checker_.DetachFromThread();
27 } 30 }
28 31
29 SurfaceManager::~SurfaceManager() { 32 SurfaceManager::~SurfaceManager() {
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 332
330 bool SurfaceManager::SurfaceModified(SurfaceId surface_id) { 333 bool SurfaceManager::SurfaceModified(SurfaceId surface_id) {
331 CHECK(thread_checker_.CalledOnValidThread()); 334 CHECK(thread_checker_.CalledOnValidThread());
332 bool changed = false; 335 bool changed = false;
333 FOR_EACH_OBSERVER(SurfaceDamageObserver, observer_list_, 336 FOR_EACH_OBSERVER(SurfaceDamageObserver, observer_list_,
334 OnSurfaceDamaged(surface_id, &changed)); 337 OnSurfaceDamaged(surface_id, &changed));
335 return changed; 338 return changed;
336 } 339 }
337 340
338 } // namespace cc 341 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698